Jan Chaloupka
327880ba51
e2e: separate tests for LowNodeUtilization strategy and evict annotation
2020-07-17 18:11:01 +02:00
Jan Chaloupka
7bb8b4feda
e2e: create and delete RC in the same function body
...
So create/delete are coupled and caller of create is responsible for calling delete as well
2020-07-17 18:06:19 +02:00
Kubernetes Prow Robot
07f476dfc4
Merge pull request #340 from damemi/update-e2e
...
Update e2e script to use Kind setup
2020-07-13 19:57:20 -07:00
Mike Dame
f5e9f07321
Move kind setup to e2e script
...
This moves the kind setup (previously used by Travis) to the e2e runner script
to accomodate the switch to Prow. This provides a KIND_E2E env var to specify
whether to run the tests in kind, or (by default) to run locally).
2020-07-13 15:49:41 -04:00
Kubernetes Prow Robot
05c69ee26a
Merge pull request #336 from lixiang233/avoid_duplicated_append_RemoveDuplicatePods
...
avoid appending list multiple times in RemoveDuplicates
2020-07-09 01:32:02 -07:00
Kubernetes Prow Robot
1623e09122
Merge pull request #332 from lixiang233/fix_test_struct_lownodeutilization
...
Add maxPodsToEvictPerNode to LowNodeUtilization testcase struct
2020-07-09 01:22:02 -07:00
lixiang
696aa7c505
rename maxPodsToEvict to maxPodsToEvictPerNode to avoid misunderstanding
2020-07-08 15:15:48 +08:00
lixiang
c53dce0805
Add maxPodsToEvictPerNode to testcase struct
2020-07-08 15:15:38 +08:00
lixiang
cd8b5a0354
avoid appending list multiple times in RemoveDuplicates
2020-07-07 14:42:53 +08:00
Kubernetes Prow Robot
b51f24eb8e
Merge pull request #333 from lixiang233/refactor_lowNodeUtilization_func
...
Support only one sorting strategy in lowNodeUtilization
2020-07-02 22:48:47 -07:00
lixiang
ae3b4368ee
support only one sorting strategy in lowNodeUtilization
2020-07-01 09:47:35 +08:00
Kubernetes Prow Robot
61eef93618
Merge pull request #330 from paulfantom/patch-1
...
examples: fix typo
2020-06-29 07:27:24 -07:00
Paweł Krupa
fa0a2ec6fe
examples: fix typo
...
Fix incorrect example causing following error in runtime:
PodsHavingTooManyRestarts thresholds not set
2020-06-28 14:28:41 +02:00
Kubernetes Prow Robot
7ece10a643
Merge pull request #328 from KohlsTechnology/go114
...
Update To Go 1.14.4
2020-06-25 08:26:39 -07:00
Sean Malloy
71c8eae47e
Update To Go 1.14.4
...
The kubernetes project has been updated to use Go 1.14.4. See below pull
request.
https://github.com/kubernetes/kubernetes/pull/88638
After making the updates to Go 1.14 "make gen" no longer worked. The
file hack/tools.go had to be created to get "make gen" working with Go
1.14.
2020-06-23 21:33:28 -05:00
Kubernetes Prow Robot
267b0837dc
Merge pull request #327 from farah/farah/klog-migration
...
Update klog to v2
2020-06-23 08:35:40 -07:00
Kubernetes Prow Robot
c713537d56
Merge pull request #322 from lixiang233/move_pod_sort
...
Move sortPodsBasedOnPriority to pod util
2020-06-22 12:21:40 -07:00
Kubernetes Prow Robot
e374229707
Merge pull request #325 from KohlsTechnology/issue-template
...
Add initial GitHub issue templates
2020-06-22 07:42:40 -07:00
Sean Malloy
f834581a8e
Fix Spelling Error
2020-06-22 09:12:22 -05:00
Ali Farah
15fcde5229
Update klog to v2
2020-06-22 20:43:22 +10:00
Sean Malloy
96c5dd3941
Add initial GitHub issue templates
...
Initially users can open a bug report, feature request, or misc request.
Bug reports and feature requests will have the "kind" label
automatically added.
2020-06-20 00:52:23 -05:00
lixiang
65a03e76bf
Add sorting to RemovePodsViolatingInterPodAntiAffinity
2020-06-19 14:11:23 +08:00
lixiang
43525f6493
Move sortPodsBasedOnPriority to podutil
2020-06-16 19:19:03 +08:00
lixiang
7457626f62
Move helper funcs to testutil
2020-06-16 19:17:28 +08:00
Kubernetes Prow Robot
08c22e8921
Merge pull request #321 from KohlsTechnology/add-event-reason
...
Add Pod Eviction Reason To Events
2020-06-15 08:53:57 -07:00
Sean Malloy
4ff533ec17
Add pod eviction reason to k8s events
...
Prior to this change the event created for every pod eviction was
identical. Instead leverage the newly added eviction reason when
creating k8s events. This makes it easier for end users to understand
why the descheduler evicted a pod when inspecting k8s events.
2020-06-10 01:13:17 -05:00
Sean Malloy
7680e3d079
Use var declaration instead of short assignmnet
...
This is a very minor refactor to use a var declaration for the reason
variable. A var declaration is being used because the zero value for
strings is an empty string.
https://golang.org/ref/spec#The_zero_value
2020-06-10 01:05:05 -05:00
Kubernetes Prow Robot
305801dd0e
Merge pull request #319 from damemi/remove-extra-eviction-log
...
Remove redundant eviction log message and add "Reason" param to EvictPod
2020-06-09 11:25:19 -07:00
Mike Dame
9951b85d60
Add optional reason parameter to EvictPod
2020-06-09 13:35:51 -04:00
Mike Dame
ff21ec9432
Remove redundant eviction log message
2020-06-09 12:17:45 -04:00
Kubernetes Prow Robot
5e15d77bf2
Merge pull request #309 from damemi/change-evict-local-storage-pods
...
Make evictLocalStoragePods a property of PodEvictor
2020-06-08 03:53:46 -07:00
Kubernetes Prow Robot
d833c73fc4
Merge pull request #317 from ingvagabund/extend-owners
...
Add myself to project reviewers
2020-06-05 10:45:44 -07:00
Kubernetes Prow Robot
795a80dfb0
Merge pull request #310 from lixiang233/ignore_no_evictable_pod_node
...
Skip evicting when no evictable pod found on node
2020-06-05 07:41:44 -07:00
Mike Dame
f5e4acdd8a
Make evictLocalStoragePods a property of PodEvictor
...
This is a minor refactor of PodEvictor to include evictLocalStoragePods as a
property (so that it doesn't need to be passed to each strategy function.) It
also removes ListEvictablePodsOnNode and extends ListPodsOnANode with an optional
"filter" function parameter, so that for example IsEvictable can be passed to it
and achieve the same results as the function formerly known as ListEvictablePodsOnNode.
This approach also now allows strategies to more explicitly extend their criteria of what
IsEvictable considers an evictable pod (such as NodeAffinity, which checks that the pod
can fit on any other node).
2020-06-05 10:28:48 -04:00
Jan Chaloupka
eb4c1bb355
Add myself to project reviewers
...
Based on https://github.com/kubernetes/community/blob/master/community-membership.md#requirements-1 :
The following apply to the part of codebase for which one would be a reviewer in an OWNERS file (for repos using the bot).
> member for at least 3 months
For a couple of years now
> Primary reviewer for at least 5 PRs to the codebase
https://github.com/kubernetes-sigs/descheduler/pull/285
https://github.com/kubernetes-sigs/descheduler/pull/275
https://github.com/kubernetes-sigs/descheduler/pull/267
https://github.com/kubernetes-sigs/descheduler/pull/254
https://github.com/kubernetes-sigs/descheduler/pull/181
> Reviewed or merged at least 20 substantial PRs to the codebase
https://github.com/kubernetes-sigs/descheduler/pulls?q=is%3Apr+is%3Aclosed+assignee%3Aingvagabund
> Knowledgeable about the codebase
yes
> Sponsored by a subproject approver
> With no objections from other approvers
> Done through PR to update the OWNERS file
this PR
> May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot
self-nominating
2020-06-04 18:16:38 +02:00
Kubernetes Prow Robot
6dfa95cc87
Merge pull request #312 from lixiang233/fix_lowUtilization_golint
...
Pass golint check for pkg/descheduler/strategies/
2020-06-04 07:09:15 -07:00
lixiang
eb9d974a8b
pass golint check for pkg/descheduler/strategies/
2020-06-04 14:33:24 +08:00
lixiang
d41a1f4a56
Ignore evicting when no evictable pod found on node
2020-06-04 10:31:15 +08:00
Kubernetes Prow Robot
138ad556a3
Merge pull request #315 from damemi/update-travis-yml
...
Remove redundant tests from Travis CI
2020-06-03 11:44:11 -07:00
Mike Dame
37124e6e45
Remove redundant tests from Travis CI
...
These tests are now covered by k8s test-infra prow tests.
2020-06-03 14:11:08 -04:00
Kubernetes Prow Robot
bd412bf87f
Merge pull request #300 from damemi/refactor-is-evictable
...
Add more verbose logging to IsEvictable checks
2020-05-29 10:03:16 -07:00
Kubernetes Prow Robot
6f9b31f568
Merge pull request #308 from damemi/fix-lint-for-ci
...
Download golangci-lint to _output/bin directory
2020-05-29 09:57:15 -07:00
Mike Dame
c858740c4f
Run golangci-lint from GOPATH
2020-05-29 12:48:42 -04:00
Kubernetes Prow Robot
bfefe634a1
Merge pull request #307 from damemi/make-verify
...
Add parent make verify target
2020-05-29 08:01:16 -07:00
Mike Dame
7b7b9e1cd7
Add parent make verify target
2020-05-29 10:23:38 -04:00
Mike Dame
0a4b8b0a25
Add more verbose logging to IsEvictable checks
2020-05-29 10:20:14 -04:00
Kubernetes Prow Robot
f28183dcbe
Merge pull request #306 from ingvagabund/make-Params-a-pointer-II
...
Add missing address of api.StrategyParameters
2020-05-29 05:53:16 -07:00
Jan Chaloupka
abdf79454f
Add missing address of api.StrategyParameters
...
https://github.com/kubernetes-sigs/descheduler/pull/285 got merged before re-running the unit tests.
2020-05-29 13:34:57 +02:00
Kubernetes Prow Robot
46b570b71d
Merge pull request #296 from ingvagabund/make-Params-a-pointer
...
Make DeschedulerStrategy.Params a pointer
2020-05-28 22:53:15 -07:00
Kubernetes Prow Robot
616a9b5f6b
Merge pull request #285 from lixiang233/Ft_change_lowUtilization_break
...
Change break condition and thresholds validation for lowUtilization
2020-05-28 07:36:02 -07:00