Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-26 05:14:13 +01:00
Code Packages Releases Activity

Merge pull request #226 from ankon/pr/node-unschedulable-typo

Browse Source 
Fix typo in function name
This commit is contained in:
Kubernetes Prow Robot
2020-02-07 08:13:47 -08:00
committed by GitHub
parent d7482bd618 c3346e9806
commit fc8c581d7a
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/descheduler/node/node.go
View File

@@ -117,9 +117,9 @@ func IsReady(node *v1.Node) bool {
return true
}
// IsNodeUschedulable checks if the node is unschedulable. This is helper function to check only in case of
// IsNodeUnschedulable checks if the node is unschedulable. This is helper function to check only in case of
// underutilized node so that they won't be accounted for.
func IsNodeUschedulable(node *v1.Node) bool {
func IsNodeUnschedulable(node *v1.Node) bool {
return node.Spec.Unschedulable
}
@@ -134,7 +134,7 @@ func PodFitsAnyNode(pod *v1.Pod, nodes []*v1.Node) bool {
continue
}
if ok {
if !IsNodeUschedulable(node) {
if !IsNodeUnschedulable(node) {
klog.V(2).Infof("Pod %v can possibly be scheduled on %v", pod.Name, node.Name)
return true
}

4
pkg/descheduler/node/node_test.go
View File

@@ -69,7 +69,7 @@ func TestReadyNodesWithNodeSelector(t *testing.T) {
}
}
func TestIsNodeUschedulable(t *testing.T) {
func TestIsNodeUnschedulable(t *testing.T) {
tests := []struct {
description string
node *v1.Node
@@ -91,7 +91,7 @@ func TestIsNodeUschedulable(t *testing.T) {
},
}
for _, test := range tests {
actualUnSchedulable := IsNodeUschedulable(test.node)
actualUnSchedulable := IsNodeUnschedulable(test.node)
if actualUnSchedulable != test.IsUnSchedulable {
t.Errorf("Test %#v failed", test.description)
}

2
pkg/descheduler/strategies/lownodeutilization.go
View File

@@ -137,7 +137,7 @@ func classifyNodes(npm NodePodsMap, thresholds api.ResourceThresholds, targetThr
nuMap := NodeUsageMap{node, usage, allPods, nonRemovablePods, bePods, bPods, gPods}
// Check if node is underutilized and if we can schedule pods on it.
if !nodeutil.IsNodeUschedulable(node) && IsNodeWithLowUtilization(usage, thresholds) {
if !nodeutil.IsNodeUnschedulable(node) && IsNodeWithLowUtilization(usage, thresholds) {
klog.V(2).Infof("Node %#v is under utilized with usage: %#v", node.Name, usage)
lowNodes = append(lowNodes, nuMap)
} else if IsNodeAboveTargetUtilization(usage, targetThresholds) {