mirror of
https://github.com/kubernetes-sigs/descheduler.git
synced 2026-01-26 13:29:11 +01:00
1.5 KiB
1.5 KiB
Description
Checklist
Please ensure your pull request meets the following criteria before submitting for review, these items will be used by reviewers to assess the quality and completeness of your changes:
- Code Readability: Is the code easy to understand, well-structured, and consistent with project conventions?
- Naming Conventions: Are variable, function, and structs descriptive and consistent?
- Code Duplication: Is there any repeated code that should be refactored?
- Function/Method Size: Are functions/methods short and focused on a single task?
- Comments & Documentation: Are comments clear, useful, and not excessive? Were comments updated where necessary?
- Error Handling: Are errors handled appropriately ?
- Testing: Are there sufficient unit/integration tests?
- Performance: Are there any obvious performance issues or unnecessary computations?
- Dependencies: Are new dependencies justified ?
- Logging & Monitoring: Is logging used appropriately (not too verbose, not too silent)?
- Backward Compatibility: Does this change break any existing functionality or APIs?
- Resource Management: Are resources (files, connections, memory) managed and released properly?
- PR Description: Is the PR description clear, providing enough context and explaining the motivation for the change?
- Documentation & Changelog: Are README and docs updated if necessary?