mirror of
https://github.com/kubernetes-sigs/descheduler.git
synced 2026-01-26 05:14:13 +01:00
423 lines
16 KiB
Go
423 lines
16 KiB
Go
/*
|
|
Copyright 2017 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package strategies
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
policyv1 "k8s.io/api/policy/v1"
|
|
"k8s.io/apimachinery/pkg/api/resource"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
"k8s.io/client-go/kubernetes/fake"
|
|
core "k8s.io/client-go/testing"
|
|
"sigs.k8s.io/descheduler/pkg/api"
|
|
"sigs.k8s.io/descheduler/pkg/descheduler/evictions"
|
|
"sigs.k8s.io/descheduler/pkg/utils"
|
|
"sigs.k8s.io/descheduler/test"
|
|
)
|
|
|
|
func buildTestPodWithImage(podName, node, image string) *v1.Pod {
|
|
pod := test.BuildTestPod(podName, 100, 0, node, test.SetRSOwnerRef)
|
|
pod.Spec.Containers = append(pod.Spec.Containers, v1.Container{
|
|
Name: image,
|
|
Image: image,
|
|
})
|
|
return pod
|
|
}
|
|
|
|
func TestFindDuplicatePods(t *testing.T) {
|
|
ctx := context.Background()
|
|
// first setup pods
|
|
node1 := test.BuildTestNode("n1", 2000, 3000, 10, nil)
|
|
node2 := test.BuildTestNode("n2", 2000, 3000, 10, nil)
|
|
|
|
p1 := test.BuildTestPod("p1", 100, 0, node1.Name, nil)
|
|
p1.Namespace = "dev"
|
|
p2 := test.BuildTestPod("p2", 100, 0, node1.Name, nil)
|
|
p2.Namespace = "dev"
|
|
p3 := test.BuildTestPod("p3", 100, 0, node1.Name, nil)
|
|
p3.Namespace = "dev"
|
|
p4 := test.BuildTestPod("p4", 100, 0, node1.Name, nil)
|
|
p5 := test.BuildTestPod("p5", 100, 0, node1.Name, nil)
|
|
p6 := test.BuildTestPod("p6", 100, 0, node1.Name, nil)
|
|
p7 := test.BuildTestPod("p7", 100, 0, node1.Name, nil)
|
|
p7.Namespace = "kube-system"
|
|
p8 := test.BuildTestPod("p8", 100, 0, node1.Name, nil)
|
|
p8.Namespace = "test"
|
|
p9 := test.BuildTestPod("p9", 100, 0, node1.Name, nil)
|
|
p9.Namespace = "test"
|
|
p10 := test.BuildTestPod("p10", 100, 0, node1.Name, nil)
|
|
p10.Namespace = "test"
|
|
p11 := test.BuildTestPod("p11", 100, 0, node1.Name, nil)
|
|
p11.Namespace = "different-images"
|
|
p12 := test.BuildTestPod("p12", 100, 0, node1.Name, nil)
|
|
p12.Namespace = "different-images"
|
|
p13 := test.BuildTestPod("p13", 100, 0, node1.Name, nil)
|
|
p13.Namespace = "different-images"
|
|
p14 := test.BuildTestPod("p14", 100, 0, node1.Name, nil)
|
|
p14.Namespace = "different-images"
|
|
|
|
// ### Evictable Pods ###
|
|
|
|
// Three Pods in the "default" Namespace, bound to same ReplicaSet. 2 should be evicted.
|
|
ownerRef1 := test.GetReplicaSetOwnerRefList()
|
|
p1.ObjectMeta.OwnerReferences = ownerRef1
|
|
p2.ObjectMeta.OwnerReferences = ownerRef1
|
|
p3.ObjectMeta.OwnerReferences = ownerRef1
|
|
|
|
// Three Pods in the "test" Namespace, bound to same ReplicaSet. 2 should be evicted.
|
|
ownerRef2 := test.GetReplicaSetOwnerRefList()
|
|
p8.ObjectMeta.OwnerReferences = ownerRef2
|
|
p9.ObjectMeta.OwnerReferences = ownerRef2
|
|
p10.ObjectMeta.OwnerReferences = ownerRef2
|
|
|
|
// ### Non-evictable Pods ###
|
|
|
|
// A DaemonSet.
|
|
p4.ObjectMeta.OwnerReferences = test.GetDaemonSetOwnerRefList()
|
|
|
|
// A Pod with local storage.
|
|
p5.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList()
|
|
p5.Spec.Volumes = []v1.Volume{
|
|
{
|
|
Name: "sample",
|
|
VolumeSource: v1.VolumeSource{
|
|
HostPath: &v1.HostPathVolumeSource{Path: "somePath"},
|
|
EmptyDir: &v1.EmptyDirVolumeSource{
|
|
SizeLimit: resource.NewQuantity(int64(10), resource.BinarySI)},
|
|
},
|
|
},
|
|
}
|
|
|
|
// A Mirror Pod.
|
|
p6.Annotations = test.GetMirrorPodAnnotation()
|
|
|
|
// A Critical Pod.
|
|
priority := utils.SystemCriticalPriority
|
|
p7.Spec.Priority = &priority
|
|
|
|
// Same owners, but different images
|
|
p11.Spec.Containers[0].Image = "foo"
|
|
p11.ObjectMeta.OwnerReferences = ownerRef1
|
|
p12.Spec.Containers[0].Image = "bar"
|
|
p12.ObjectMeta.OwnerReferences = ownerRef1
|
|
|
|
// Multiple containers
|
|
p13.ObjectMeta.OwnerReferences = ownerRef1
|
|
p13.Spec.Containers = append(p13.Spec.Containers, v1.Container{
|
|
Name: "foo",
|
|
Image: "foo",
|
|
})
|
|
|
|
testCases := []struct {
|
|
description string
|
|
maxPodsToEvictPerNode int
|
|
pods []v1.Pod
|
|
expectedEvictedPodCount int
|
|
strategy api.DeschedulerStrategy
|
|
}{
|
|
{
|
|
description: "Three pods in the `dev` Namespace, bound to same ReplicaSet. 1 should be evicted.",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p1, *p2, *p3},
|
|
expectedEvictedPodCount: 1,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Three pods in the `dev` Namespace, bound to same ReplicaSet, but ReplicaSet kind is excluded. 0 should be evicted.",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p1, *p2, *p3},
|
|
expectedEvictedPodCount: 0,
|
|
strategy: api.DeschedulerStrategy{Params: &api.StrategyParameters{RemoveDuplicates: &api.RemoveDuplicates{ExcludeOwnerKinds: []string{"ReplicaSet"}}}},
|
|
},
|
|
{
|
|
description: "Three Pods in the `test` Namespace, bound to same ReplicaSet. 1 should be evicted.",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p8, *p9, *p10},
|
|
expectedEvictedPodCount: 1,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Three Pods in the `dev` Namespace, three Pods in the `test` Namespace. Bound to ReplicaSet with same name. 4 should be evicted.",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p1, *p2, *p3, *p8, *p9, *p10},
|
|
expectedEvictedPodCount: 2,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Pods are: part of DaemonSet, with local storage, mirror pod annotation, critical pod annotation - none should be evicted.",
|
|
maxPodsToEvictPerNode: 2,
|
|
pods: []v1.Pod{*p4, *p5, *p6, *p7},
|
|
expectedEvictedPodCount: 0,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Test all Pods: 4 should be evicted.",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p1, *p2, *p3, *p4, *p5, *p6, *p7, *p8, *p9, *p10},
|
|
expectedEvictedPodCount: 2,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Pods with the same owner but different images should not be evicted",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p11, *p12},
|
|
expectedEvictedPodCount: 0,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Pods with multiple containers should not match themselves",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p13},
|
|
expectedEvictedPodCount: 0,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Pods with matching ownerrefs and at not all matching image should not trigger an eviction",
|
|
maxPodsToEvictPerNode: 5,
|
|
pods: []v1.Pod{*p11, *p13},
|
|
expectedEvictedPodCount: 0,
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.description, func(t *testing.T) {
|
|
fakeClient := &fake.Clientset{}
|
|
fakeClient.Fake.AddReactor("list", "pods", func(action core.Action) (bool, runtime.Object, error) {
|
|
return true, &v1.PodList{Items: testCase.pods}, nil
|
|
})
|
|
podEvictor := evictions.NewPodEvictor(
|
|
fakeClient,
|
|
"v1",
|
|
false,
|
|
testCase.maxPodsToEvictPerNode,
|
|
[]*v1.Node{node1, node2},
|
|
false,
|
|
false,
|
|
false,
|
|
)
|
|
|
|
RemoveDuplicatePods(ctx, fakeClient, testCase.strategy, []*v1.Node{node1, node2}, podEvictor)
|
|
podsEvicted := podEvictor.TotalEvicted()
|
|
if podsEvicted != testCase.expectedEvictedPodCount {
|
|
t.Errorf("Test error for description: %s. Expected evicted pods count %v, got %v", testCase.description, testCase.expectedEvictedPodCount, podsEvicted)
|
|
}
|
|
})
|
|
}
|
|
|
|
}
|
|
|
|
func TestRemoveDuplicatesUniformly(t *testing.T) {
|
|
ctx := context.Background()
|
|
|
|
setRSOwnerRef2 := func(pod *v1.Pod) {
|
|
pod.ObjectMeta.OwnerReferences = []metav1.OwnerReference{
|
|
{Kind: "ReplicaSet", APIVersion: "v1", Name: "replicaset-2"},
|
|
}
|
|
}
|
|
setTwoRSOwnerRef := func(pod *v1.Pod) {
|
|
pod.ObjectMeta.OwnerReferences = []metav1.OwnerReference{
|
|
{Kind: "ReplicaSet", APIVersion: "v1", Name: "replicaset-1"},
|
|
{Kind: "ReplicaSet", APIVersion: "v1", Name: "replicaset-2"},
|
|
}
|
|
}
|
|
|
|
testCases := []struct {
|
|
description string
|
|
maxPodsToEvictPerNode int
|
|
pods []v1.Pod
|
|
nodes []*v1.Node
|
|
expectedEvictedPodCount int
|
|
strategy api.DeschedulerStrategy
|
|
}{
|
|
{
|
|
description: "Evict pods uniformly",
|
|
pods: []v1.Pod{
|
|
// (5,3,1) -> (3,3,3) -> 2 evictions
|
|
*test.BuildTestPod("p1", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p2", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p3", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p4", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p5", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p6", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p7", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p8", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p9", 100, 0, "n3", test.SetRSOwnerRef),
|
|
},
|
|
expectedEvictedPodCount: 2,
|
|
nodes: []*v1.Node{
|
|
test.BuildTestNode("n1", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n2", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n3", 2000, 3000, 10, nil),
|
|
},
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Evict pods uniformly with one node left out",
|
|
pods: []v1.Pod{
|
|
// (5,3,1) -> (4,4,1) -> 1 eviction
|
|
*test.BuildTestPod("p1", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p2", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p3", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p4", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p5", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p6", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p7", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p8", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p9", 100, 0, "n3", test.SetRSOwnerRef),
|
|
},
|
|
expectedEvictedPodCount: 1,
|
|
nodes: []*v1.Node{
|
|
test.BuildTestNode("n1", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n2", 2000, 3000, 10, nil),
|
|
},
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Evict pods uniformly with two replica sets",
|
|
pods: []v1.Pod{
|
|
// (5,3,1) -> (3,3,3) -> 2 evictions
|
|
*test.BuildTestPod("p11", 100, 0, "n1", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p12", 100, 0, "n1", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p13", 100, 0, "n1", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p14", 100, 0, "n1", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p15", 100, 0, "n1", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p16", 100, 0, "n2", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p17", 100, 0, "n2", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p18", 100, 0, "n2", setTwoRSOwnerRef),
|
|
*test.BuildTestPod("p19", 100, 0, "n3", setTwoRSOwnerRef),
|
|
},
|
|
expectedEvictedPodCount: 4,
|
|
nodes: []*v1.Node{
|
|
test.BuildTestNode("n1", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n2", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n3", 2000, 3000, 10, nil),
|
|
},
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Evict pods uniformly with two owner references",
|
|
pods: []v1.Pod{
|
|
// (5,3,1) -> (3,3,3) -> 2 evictions
|
|
*test.BuildTestPod("p11", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p12", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p13", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p14", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p15", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p16", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p17", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p18", 100, 0, "n2", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p19", 100, 0, "n3", test.SetRSOwnerRef),
|
|
// (1,3,5) -> (3,3,3) -> 2 evictions
|
|
*test.BuildTestPod("p21", 100, 0, "n1", setRSOwnerRef2),
|
|
*test.BuildTestPod("p22", 100, 0, "n2", setRSOwnerRef2),
|
|
*test.BuildTestPod("p23", 100, 0, "n2", setRSOwnerRef2),
|
|
*test.BuildTestPod("p24", 100, 0, "n2", setRSOwnerRef2),
|
|
*test.BuildTestPod("p25", 100, 0, "n3", setRSOwnerRef2),
|
|
*test.BuildTestPod("p26", 100, 0, "n3", setRSOwnerRef2),
|
|
*test.BuildTestPod("p27", 100, 0, "n3", setRSOwnerRef2),
|
|
*test.BuildTestPod("p28", 100, 0, "n3", setRSOwnerRef2),
|
|
*test.BuildTestPod("p29", 100, 0, "n3", setRSOwnerRef2),
|
|
},
|
|
expectedEvictedPodCount: 4,
|
|
nodes: []*v1.Node{
|
|
test.BuildTestNode("n1", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n2", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n3", 2000, 3000, 10, nil),
|
|
},
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Evict pods with number of pods less than nodes",
|
|
pods: []v1.Pod{
|
|
// (2,0,0) -> (1,1,0) -> 1 eviction
|
|
*test.BuildTestPod("p1", 100, 0, "n1", test.SetRSOwnerRef),
|
|
*test.BuildTestPod("p2", 100, 0, "n1", test.SetRSOwnerRef),
|
|
},
|
|
expectedEvictedPodCount: 1,
|
|
nodes: []*v1.Node{
|
|
test.BuildTestNode("n1", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n2", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n3", 2000, 3000, 10, nil),
|
|
},
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Evict pods with number of pods less than nodes, but ignore different pods with the same ownerref",
|
|
pods: []v1.Pod{
|
|
// (1, 0, 0) for "bar","baz" images -> no eviction, even with a matching ownerKey
|
|
// (2, 0, 0) for "foo" image -> (1,1,0) - 1 eviction
|
|
// In this case the only "real" duplicates are p1 and p4, so one of those should be evicted
|
|
*buildTestPodWithImage("p1", "n1", "foo"),
|
|
*buildTestPodWithImage("p2", "n1", "bar"),
|
|
*buildTestPodWithImage("p3", "n1", "baz"),
|
|
*buildTestPodWithImage("p4", "n1", "foo"),
|
|
},
|
|
expectedEvictedPodCount: 1,
|
|
nodes: []*v1.Node{
|
|
test.BuildTestNode("n1", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n2", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n3", 2000, 3000, 10, nil),
|
|
},
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
{
|
|
description: "Evict pods with a single pod with three nodes",
|
|
pods: []v1.Pod{
|
|
// (2,0,0) -> (1,1,0) -> 1 eviction
|
|
*test.BuildTestPod("p1", 100, 0, "n1", test.SetRSOwnerRef),
|
|
},
|
|
expectedEvictedPodCount: 0,
|
|
nodes: []*v1.Node{
|
|
test.BuildTestNode("n1", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n2", 2000, 3000, 10, nil),
|
|
test.BuildTestNode("n3", 2000, 3000, 10, nil),
|
|
},
|
|
strategy: api.DeschedulerStrategy{},
|
|
},
|
|
}
|
|
|
|
for _, testCase := range testCases {
|
|
t.Run(testCase.description, func(t *testing.T) {
|
|
fakeClient := &fake.Clientset{}
|
|
fakeClient.Fake.AddReactor("list", "pods", func(action core.Action) (bool, runtime.Object, error) {
|
|
return true, &v1.PodList{Items: testCase.pods}, nil
|
|
})
|
|
podEvictor := evictions.NewPodEvictor(
|
|
fakeClient,
|
|
policyv1.SchemeGroupVersion.String(),
|
|
false,
|
|
testCase.maxPodsToEvictPerNode,
|
|
testCase.nodes,
|
|
false,
|
|
false,
|
|
false,
|
|
)
|
|
|
|
RemoveDuplicatePods(ctx, fakeClient, testCase.strategy, testCase.nodes, podEvictor)
|
|
podsEvicted := podEvictor.TotalEvicted()
|
|
if podsEvicted != testCase.expectedEvictedPodCount {
|
|
t.Errorf("Test error for description: %s. Expected evicted pods count %v, got %v", testCase.description, testCase.expectedEvictedPodCount, podsEvicted)
|
|
}
|
|
})
|
|
}
|
|
}
|