mirror of
https://github.com/kubernetes-sigs/descheduler.git
synced 2026-01-26 13:29:11 +01:00
6e953b2ff3
* Remove log level from Errors Every error printed via Errors is expected to be important and always printable. * Invoke first Deschedule and then Balance extension points (breaking change) * Separate plugin arg conversion from pluginsMap * Seperate profile population from plugin execution * Convert strategy params into profiles outside the main descheduling loop Strategy params are static and do not change in time. * Bump the internal DeschedulerPolicy to v1alpha2 Drop conversion from v1alpha1 to internal * add tests to v1alpha1 to internal conversion * add tests to strategyParamsToPluginArgs params wiring * in v1alpha1 evictableNamespaces are still Namespaces * add test passing in all params Co-authored-by: Lucas Severo Alves <lseveroa@redhat.com>
82 lines
3.0 KiB
Go
82 lines
3.0 KiB
Go
/*
|
|
Copyright 2022 The Kubernetes Authors.
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package nodeutilization
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"sigs.k8s.io/descheduler/pkg/api"
|
|
)
|
|
|
|
func ValidateHighNodeUtilizationArgs(args *HighNodeUtilizationArgs) error {
|
|
// only exclude can be set, or not at all
|
|
if args.EvictableNamespaces != nil && len(args.EvictableNamespaces.Include) > 0 {
|
|
return fmt.Errorf("only Exclude namespaces can be set, inclusion is not supported")
|
|
}
|
|
err := validateThresholds(args.Thresholds)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func ValidateLowNodeUtilizationArgs(args *LowNodeUtilizationArgs) error {
|
|
// only exclude can be set, or not at all
|
|
if args.EvictableNamespaces != nil && len(args.EvictableNamespaces.Include) > 0 {
|
|
return fmt.Errorf("only Exclude namespaces can be set, inclusion is not supported")
|
|
}
|
|
err := validateLowNodeUtilizationThresholds(args.Thresholds, args.TargetThresholds, args.UseDeviationThresholds)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func validateLowNodeUtilizationThresholds(thresholds, targetThresholds api.ResourceThresholds, useDeviationThresholds bool) error {
|
|
// validate thresholds and targetThresholds config
|
|
if err := validateThresholds(thresholds); err != nil {
|
|
return fmt.Errorf("thresholds config is not valid: %v", err)
|
|
}
|
|
if err := validateThresholds(targetThresholds); err != nil {
|
|
return fmt.Errorf("targetThresholds config is not valid: %v", err)
|
|
}
|
|
|
|
// validate if thresholds and targetThresholds have same resources configured
|
|
if len(thresholds) != len(targetThresholds) {
|
|
return fmt.Errorf("thresholds and targetThresholds configured different resources")
|
|
}
|
|
for resourceName, value := range thresholds {
|
|
if targetValue, ok := targetThresholds[resourceName]; !ok {
|
|
return fmt.Errorf("thresholds and targetThresholds configured different resources")
|
|
} else if value > targetValue && !useDeviationThresholds {
|
|
return fmt.Errorf("thresholds' %v percentage is greater than targetThresholds'", resourceName)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// validateThresholds checks if thresholds have valid resource name and resource percentage configured
|
|
func validateThresholds(thresholds api.ResourceThresholds) error {
|
|
if len(thresholds) == 0 {
|
|
return fmt.Errorf("no resource threshold is configured")
|
|
}
|
|
for name, percent := range thresholds {
|
|
if percent < MinResourcePercentage || percent > MaxResourcePercentage {
|
|
return fmt.Errorf("%v threshold not in [%v, %v] range", name, MinResourcePercentage, MaxResourcePercentage)
|
|
}
|
|
}
|
|
return nil
|
|
}
|