mirror of
https://github.com/kubernetes-sigs/descheduler.git
synced 2026-01-26 13:29:11 +01:00
6e953b2ff3
* Remove log level from Errors Every error printed via Errors is expected to be important and always printable. * Invoke first Deschedule and then Balance extension points (breaking change) * Separate plugin arg conversion from pluginsMap * Seperate profile population from plugin execution * Convert strategy params into profiles outside the main descheduling loop Strategy params are static and do not change in time. * Bump the internal DeschedulerPolicy to v1alpha2 Drop conversion from v1alpha1 to internal * add tests to v1alpha1 to internal conversion * add tests to strategyParamsToPluginArgs params wiring * in v1alpha1 evictableNamespaces are still Namespaces * add test passing in all params Co-authored-by: Lucas Severo Alves <lseveroa@redhat.com>
845 lines
25 KiB
Go
845 lines
25 KiB
Go
/*
|
|
Copyright 2022 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package descheduler
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
utilpointer "k8s.io/utils/pointer"
|
|
"sigs.k8s.io/descheduler/pkg/api"
|
|
"sigs.k8s.io/descheduler/pkg/api/v1alpha1"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/nodeutilization"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/podlifetime"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/removeduplicates"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/removefailedpods"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatinginterpodantiaffinity"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingnodeaffinity"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingnodetaints"
|
|
"sigs.k8s.io/descheduler/pkg/framework/plugins/removepodsviolatingtopologyspreadconstraint"
|
|
)
|
|
|
|
func TestStrategyParamsToPluginArgsRemovePodsViolatingNodeTaints(t *testing.T) {
|
|
strategyName := "RemovePodsViolatingNodeTaints"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
ExcludedTaints: []string{
|
|
"dedicated=special-user",
|
|
"reserved",
|
|
},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: removepodsviolatingnodetaints.PluginName,
|
|
Args: &removepodsviolatingnodetaints.RemovePodsViolatingNodeTaintsArgs{
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
ExcludedTaints: []string{"dedicated=special-user", "reserved"},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsRemoveFailedPods(t *testing.T) {
|
|
strategyName := "RemoveFailedPods"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
FailedPods: &v1alpha1.FailedPods{
|
|
MinPodLifetimeSeconds: utilpointer.Uint(3600),
|
|
ExcludeOwnerKinds: []string{"Job"},
|
|
Reasons: []string{"NodeAffinity"},
|
|
IncludingInitContainers: true,
|
|
},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: removefailedpods.PluginName,
|
|
Args: &removefailedpods.RemoveFailedPodsArgs{
|
|
ExcludeOwnerKinds: []string{"Job"},
|
|
MinPodLifetimeSeconds: utilpointer.Uint(3600),
|
|
Reasons: []string{"NodeAffinity"},
|
|
IncludingInitContainers: true,
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsRemovePodsViolatingNodeAffinity(t *testing.T) {
|
|
strategyName := "RemovePodsViolatingNodeAffinity"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeAffinityType: []string{"requiredDuringSchedulingIgnoredDuringExecution"},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: removepodsviolatingnodeaffinity.PluginName,
|
|
Args: &removepodsviolatingnodeaffinity.RemovePodsViolatingNodeAffinityArgs{
|
|
NodeAffinityType: []string{"requiredDuringSchedulingIgnoredDuringExecution"},
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params, not setting nodeaffinity type",
|
|
params: &v1alpha1.StrategyParameters{},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: nodeAffinityType needs to be set", strategyName),
|
|
result: nil,
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeAffinityType: []string{"requiredDuringSchedulingIgnoredDuringExecution"},
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsRemovePodsViolatingInterPodAntiAffinity(t *testing.T) {
|
|
strategyName := "RemovePodsViolatingInterPodAntiAffinity"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: removepodsviolatinginterpodantiaffinity.PluginName,
|
|
Args: &removepodsviolatinginterpodantiaffinity.RemovePodsViolatingInterPodAntiAffinityArgs{
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsRemovePodsHavingTooManyRestarts(t *testing.T) {
|
|
strategyName := "RemovePodsHavingTooManyRestarts"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
PodsHavingTooManyRestarts: &v1alpha1.PodsHavingTooManyRestarts{
|
|
PodRestartThreshold: 100,
|
|
IncludingInitContainers: true,
|
|
},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: removepodshavingtoomanyrestarts.PluginName,
|
|
Args: &removepodshavingtoomanyrestarts.RemovePodsHavingTooManyRestartsArgs{
|
|
PodRestartThreshold: 100,
|
|
IncludingInitContainers: true,
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
{
|
|
description: "invalid params restart threshold",
|
|
params: &v1alpha1.StrategyParameters{
|
|
PodsHavingTooManyRestarts: &v1alpha1.PodsHavingTooManyRestarts{
|
|
PodRestartThreshold: 0,
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: invalid PodsHavingTooManyRestarts threshold", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsPodLifeTime(t *testing.T) {
|
|
strategyName := "PodLifeTime"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
PodLifeTime: &v1alpha1.PodLifeTime{
|
|
MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
|
|
States: []string{
|
|
"Pending",
|
|
"PodInitializing",
|
|
},
|
|
},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: podlifetime.PluginName,
|
|
Args: &podlifetime.PodLifeTimeArgs{
|
|
MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
|
|
States: []string{
|
|
"Pending",
|
|
"PodInitializing",
|
|
},
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
PodLifeTime: &v1alpha1.PodLifeTime{
|
|
MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
|
|
},
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
{
|
|
description: "invalid params MaxPodLifeTimeSeconds not set",
|
|
params: &v1alpha1.StrategyParameters{
|
|
PodLifeTime: &v1alpha1.PodLifeTime{},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: MaxPodLifeTimeSeconds not set", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsRemoveDuplicates(t *testing.T) {
|
|
strategyName := "RemoveDuplicates"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
RemoveDuplicates: &v1alpha1.RemoveDuplicates{
|
|
ExcludeOwnerKinds: []string{"ReplicaSet"},
|
|
},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: removeduplicates.PluginName,
|
|
Args: &removeduplicates.RemoveDuplicatesArgs{
|
|
ExcludeOwnerKinds: []string{"ReplicaSet"},
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
PodLifeTime: &v1alpha1.PodLifeTime{
|
|
MaxPodLifeTimeSeconds: utilpointer.Uint(86400),
|
|
},
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsRemovePodsViolatingTopologySpreadConstraint(t *testing.T) {
|
|
strategyName := "RemovePodsViolatingTopologySpreadConstraint"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
IncludeSoftConstraints: true,
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: removepodsviolatingtopologyspreadconstraint.PluginName,
|
|
Args: &removepodsviolatingtopologyspreadconstraint.RemovePodsViolatingTopologySpreadConstraintArgs{
|
|
IncludeSoftConstraints: true,
|
|
Namespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only one of Include/Exclude namespaces can be set", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsHighNodeUtilization(t *testing.T) {
|
|
strategyName := "HighNodeUtilization"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
Thresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(20),
|
|
"memory": v1alpha1.Percentage(20),
|
|
"pods": v1alpha1.Percentage(20),
|
|
},
|
|
},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: nodeutilization.HighNodeUtilizationPluginName,
|
|
Args: &nodeutilization.HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
"cpu": api.Percentage(20),
|
|
"memory": api.Percentage(20),
|
|
"pods": api.Percentage(20),
|
|
},
|
|
NumberOfNodes: 3,
|
|
EvictableNamespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
Thresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(20),
|
|
"memory": v1alpha1.Percentage(20),
|
|
"pods": v1alpha1.Percentage(20),
|
|
},
|
|
},
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only Exclude namespaces can be set, inclusion is not supported", strategyName),
|
|
result: nil,
|
|
},
|
|
{
|
|
description: "invalid params nil ResourceThresholds",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: no resource threshold is configured", strategyName),
|
|
result: nil,
|
|
},
|
|
{
|
|
description: "invalid params out of bounds threshold",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
Thresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(150),
|
|
},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: cpu threshold not in [0, 100] range", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestStrategyParamsToPluginArgsLowNodeUtilization(t *testing.T) {
|
|
strategyName := "LowNodeUtilization"
|
|
type testCase struct {
|
|
description string
|
|
params *v1alpha1.StrategyParameters
|
|
err error
|
|
result *api.PluginConfig
|
|
}
|
|
testCases := []testCase{
|
|
{
|
|
description: "wire in all valid parameters",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
Thresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(20),
|
|
"memory": v1alpha1.Percentage(20),
|
|
"pods": v1alpha1.Percentage(20),
|
|
},
|
|
TargetThresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(50),
|
|
"memory": v1alpha1.Percentage(50),
|
|
"pods": v1alpha1.Percentage(50),
|
|
},
|
|
UseDeviationThresholds: true,
|
|
},
|
|
ThresholdPriority: utilpointer.Int32(100),
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
err: nil,
|
|
result: &api.PluginConfig{
|
|
Name: nodeutilization.LowNodeUtilizationPluginName,
|
|
Args: &nodeutilization.LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
"cpu": api.Percentage(20),
|
|
"memory": api.Percentage(20),
|
|
"pods": api.Percentage(20),
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
"cpu": api.Percentage(50),
|
|
"memory": api.Percentage(50),
|
|
"pods": api.Percentage(50),
|
|
},
|
|
UseDeviationThresholds: true,
|
|
NumberOfNodes: 3,
|
|
EvictableNamespaces: &api.Namespaces{
|
|
Exclude: []string{"test1"},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
description: "invalid params namespaces",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
Thresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(20),
|
|
"memory": v1alpha1.Percentage(20),
|
|
"pods": v1alpha1.Percentage(20),
|
|
},
|
|
TargetThresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(50),
|
|
"memory": v1alpha1.Percentage(50),
|
|
"pods": v1alpha1.Percentage(50),
|
|
},
|
|
UseDeviationThresholds: true,
|
|
},
|
|
Namespaces: &v1alpha1.Namespaces{
|
|
Include: []string{"test2"},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: only Exclude namespaces can be set, inclusion is not supported", strategyName),
|
|
result: nil,
|
|
},
|
|
{
|
|
description: "invalid params nil ResourceThresholds",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: thresholds config is not valid: no resource threshold is configured", strategyName),
|
|
result: nil,
|
|
},
|
|
{
|
|
description: "invalid params out of bounds threshold",
|
|
params: &v1alpha1.StrategyParameters{
|
|
NodeResourceUtilizationThresholds: &v1alpha1.NodeResourceUtilizationThresholds{
|
|
NumberOfNodes: 3,
|
|
Thresholds: v1alpha1.ResourceThresholds{
|
|
"cpu": v1alpha1.Percentage(150),
|
|
},
|
|
},
|
|
},
|
|
err: fmt.Errorf("strategy \"%s\" param validation failed: thresholds config is not valid: cpu threshold not in [0, 100] range", strategyName),
|
|
result: nil,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.description, func(t *testing.T) {
|
|
var result *api.PluginConfig
|
|
var err error
|
|
if pcFnc, exists := strategyParamsToPluginArgs[strategyName]; exists {
|
|
result, err = pcFnc(tc.params)
|
|
}
|
|
if err != nil {
|
|
if err.Error() != tc.err.Error() {
|
|
t.Errorf("unexpected error: %s", err.Error())
|
|
}
|
|
}
|
|
if err == nil {
|
|
// sort to easily compare deepequality
|
|
diff := cmp.Diff(tc.result, result)
|
|
if diff != "" {
|
|
t.Errorf("test '%s' failed. Results are not deep equal. mismatch (-want +got):\n%s", tc.description, diff)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|