mirror of
https://github.com/kubernetes-sigs/descheduler.git
synced 2026-01-26 05:14:13 +01:00
395 lines
11 KiB
Go
395 lines
11 KiB
Go
/*
|
|
Copyright 2022 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package nodeutilization
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
v1 "k8s.io/api/core/v1"
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
|
|
"sigs.k8s.io/descheduler/pkg/api"
|
|
)
|
|
|
|
func TestValidateLowNodeUtilizationPluginConfig(t *testing.T) {
|
|
extendedResource := v1.ResourceName("example.com/foo")
|
|
tests := []struct {
|
|
name string
|
|
args *LowNodeUtilizationArgs
|
|
errInfo error
|
|
}{
|
|
{
|
|
name: "passing invalid thresholds",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 120,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds config is not valid: %v", fmt.Errorf(
|
|
"%v threshold not in [%v, %v] range", v1.ResourceMemory, MinResourcePercentage, MaxResourcePercentage)),
|
|
},
|
|
{
|
|
name: "thresholds and targetThresholds configured different num of resources",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
v1.ResourcePods: 80,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds and targetThresholds configured different resources"),
|
|
},
|
|
{
|
|
name: "thresholds and targetThresholds configured different resources",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourcePods: 80,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds and targetThresholds configured different resources"),
|
|
},
|
|
{
|
|
name: "thresholds' CPU config value is greater than targetThresholds'",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 90,
|
|
v1.ResourceMemory: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds' %v percentage is greater than targetThresholds'", v1.ResourceCPU),
|
|
},
|
|
{
|
|
name: "only thresholds configured extended resource",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
extendedResource: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds and targetThresholds configured different resources"),
|
|
},
|
|
{
|
|
name: "only targetThresholds configured extended resource",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
extendedResource: 80,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds and targetThresholds configured different resources"),
|
|
},
|
|
{
|
|
name: "thresholds and targetThresholds configured different extended resources",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
extendedResource: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
"example.com/bar": 80,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds and targetThresholds configured different resources"),
|
|
},
|
|
{
|
|
name: "thresholds' extended resource config value is greater than targetThresholds'",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
extendedResource: 90,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
extendedResource: 20,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("thresholds' %v percentage is greater than targetThresholds'", extendedResource),
|
|
},
|
|
{
|
|
name: "passing valid plugin config",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
},
|
|
},
|
|
errInfo: nil,
|
|
},
|
|
{
|
|
name: "passing valid plugin config with extended resource",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
extendedResource: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
extendedResource: 80,
|
|
},
|
|
},
|
|
errInfo: nil,
|
|
},
|
|
{
|
|
name: "setting both kubernetes metrics source and metricsserver",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
extendedResource: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
extendedResource: 80,
|
|
},
|
|
MetricsUtilization: &MetricsUtilization{
|
|
MetricsServer: true,
|
|
Source: api.KubernetesMetrics,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("it is not allowed to set both \"KubernetesMetrics\" source and metricsServer"),
|
|
},
|
|
{
|
|
name: "missing prometheus query",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
extendedResource: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
extendedResource: 80,
|
|
},
|
|
MetricsUtilization: &MetricsUtilization{
|
|
Source: api.PrometheusMetrics,
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("prometheus query is required when metrics source is set to \"Prometheus\""),
|
|
},
|
|
{
|
|
name: "prometheus set when source set to kubernetes metrics",
|
|
args: &LowNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 20,
|
|
v1.ResourceMemory: 20,
|
|
extendedResource: 20,
|
|
},
|
|
TargetThresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 80,
|
|
extendedResource: 80,
|
|
},
|
|
MetricsUtilization: &MetricsUtilization{
|
|
Source: api.KubernetesMetrics,
|
|
Prometheus: &Prometheus{},
|
|
},
|
|
},
|
|
errInfo: fmt.Errorf("prometheus configuration is not allowed to set when source is set to \"KubernetesMetrics\""),
|
|
},
|
|
}
|
|
|
|
for _, testCase := range tests {
|
|
t.Run(testCase.name, func(t *testing.T) {
|
|
validateErr := ValidateLowNodeUtilizationArgs(runtime.Object(testCase.args))
|
|
if validateErr == nil || testCase.errInfo == nil {
|
|
if validateErr != testCase.errInfo {
|
|
t.Errorf("expected validity of plugin config: %q but got %q instead", testCase.errInfo, validateErr)
|
|
}
|
|
} else if validateErr.Error() != testCase.errInfo.Error() {
|
|
t.Errorf("expected validity of plugin config: %q but got %q instead", testCase.errInfo, validateErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateHighNodeUtilizationPluginConfig(t *testing.T) {
|
|
extendedResource := v1.ResourceName("example.com/foo")
|
|
|
|
tests := []struct {
|
|
name string
|
|
args *HighNodeUtilizationArgs
|
|
wantErr bool
|
|
errMsg string
|
|
}{
|
|
{
|
|
name: "valid configuration with CPU and memory",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
v1.ResourceMemory: 90,
|
|
},
|
|
EvictionModes: []EvictionMode{EvictionModeOnlyThresholdingResources},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "valid configuration with extended resource",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 85,
|
|
extendedResource: 95,
|
|
},
|
|
EvictionModes: []EvictionMode{EvictionModeOnlyThresholdingResources},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "empty thresholds",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{},
|
|
},
|
|
wantErr: true,
|
|
errMsg: "no resource threshold is configured",
|
|
},
|
|
{
|
|
name: "threshold below minimum (0%)",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: -1,
|
|
},
|
|
},
|
|
wantErr: true,
|
|
errMsg: "cpu threshold not in [0, 100] range",
|
|
},
|
|
{
|
|
name: "threshold above maximum (100%)",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceMemory: 101,
|
|
},
|
|
},
|
|
wantErr: true,
|
|
errMsg: "memory threshold not in [0, 100] range",
|
|
},
|
|
{
|
|
name: "multiple thresholds with one out of range",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 50,
|
|
v1.ResourceMemory: 150,
|
|
},
|
|
},
|
|
wantErr: true,
|
|
errMsg: "memory threshold not in [0, 100] range",
|
|
},
|
|
{
|
|
name: "evictableNamespaces with Exclude (allowed)",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
},
|
|
EvictableNamespaces: &api.Namespaces{
|
|
Exclude: []string{"ns1", "ns2"},
|
|
},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "invalid eviction mode",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
},
|
|
EvictionModes: []EvictionMode{"InvalidMode"},
|
|
},
|
|
wantErr: true,
|
|
errMsg: "invalid eviction mode InvalidMode",
|
|
},
|
|
{
|
|
name: "missing eviction modes (nil) - should be allowed (treated as empty)",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
},
|
|
EvictionModes: nil,
|
|
},
|
|
wantErr: false,
|
|
},
|
|
{
|
|
name: "empty eviction modes slice - should be allowed",
|
|
args: &HighNodeUtilizationArgs{
|
|
Thresholds: api.ResourceThresholds{
|
|
v1.ResourceCPU: 80,
|
|
},
|
|
EvictionModes: []EvictionMode{},
|
|
},
|
|
wantErr: false,
|
|
},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
err := ValidateHighNodeUtilizationArgs(runtime.Object(tc.args))
|
|
|
|
if tc.wantErr {
|
|
if err == nil {
|
|
t.Fatalf("expected error, but got nil")
|
|
}
|
|
if tc.errMsg != "" && err.Error() != tc.errMsg {
|
|
t.Errorf("expected error message: %q, but got: %q", tc.errMsg, err.Error())
|
|
}
|
|
} else {
|
|
if err != nil {
|
|
t.Errorf("unexpected error: %v", err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|