/* Copyright 2017 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package removepodsviolatinginterpodantiaffinity import ( "context" "testing" v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/client-go/informers" "k8s.io/client-go/kubernetes/fake" "k8s.io/client-go/tools/events" frameworktypes "sigs.k8s.io/descheduler/pkg/framework/types" "sigs.k8s.io/descheduler/pkg/descheduler/evictions" podutil "sigs.k8s.io/descheduler/pkg/descheduler/pod" frameworkfake "sigs.k8s.io/descheduler/pkg/framework/fake" "sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor" "sigs.k8s.io/descheduler/pkg/utils" "sigs.k8s.io/descheduler/test" ) func TestPodAntiAffinity(t *testing.T) { node1 := test.BuildTestNode("n1", 2000, 3000, 10, func(node *v1.Node) { node.ObjectMeta.Labels = map[string]string{ "region": "main-region", } }) node2 := test.BuildTestNode("n2", 2000, 3000, 10, func(node *v1.Node) { node.ObjectMeta.Labels = map[string]string{ "datacenter": "east", } }) node3 := test.BuildTestNode("n3", 2000, 3000, 10, func(node *v1.Node) { node.Spec = v1.NodeSpec{ Unschedulable: true, } }) node4 := test.BuildTestNode("n4", 2, 2, 1, nil) node5 := test.BuildTestNode("n5", 200, 3000, 10, func(node *v1.Node) { node.ObjectMeta.Labels = map[string]string{ "region": "main-region", } }) p1 := test.BuildTestPod("p1", 100, 0, node1.Name, nil) p2 := test.BuildTestPod("p2", 100, 0, node1.Name, nil) p3 := test.BuildTestPod("p3", 100, 0, node1.Name, nil) p4 := test.BuildTestPod("p4", 100, 0, node1.Name, nil) p5 := test.BuildTestPod("p5", 100, 0, node1.Name, nil) p6 := test.BuildTestPod("p6", 100, 0, node1.Name, nil) p7 := test.BuildTestPod("p7", 100, 0, node1.Name, nil) p8 := test.BuildTestPod("p8", 100, 0, node1.Name, nil) p9 := test.BuildTestPod("p9", 100, 0, node1.Name, nil) p10 := test.BuildTestPod("p10", 100, 0, node1.Name, nil) p11 := test.BuildTestPod("p11", 100, 0, node5.Name, nil) p9.DeletionTimestamp = &metav1.Time{} p10.DeletionTimestamp = &metav1.Time{} criticalPriority := utils.SystemCriticalPriority nonEvictablePod := test.BuildTestPod("non-evict", 100, 0, node1.Name, func(pod *v1.Pod) { pod.Spec.Priority = &criticalPriority }) p2.Labels = map[string]string{"foo": "bar"} p5.Labels = map[string]string{"foo": "bar"} p6.Labels = map[string]string{"foo": "bar"} p7.Labels = map[string]string{"foo1": "bar1"} p11.Labels = map[string]string{"foo": "bar"} nonEvictablePod.Labels = map[string]string{"foo": "bar"} test.SetNormalOwnerRef(p1) test.SetNormalOwnerRef(p2) test.SetNormalOwnerRef(p3) test.SetNormalOwnerRef(p4) test.SetNormalOwnerRef(p5) test.SetNormalOwnerRef(p6) test.SetNormalOwnerRef(p7) test.SetNormalOwnerRef(p9) test.SetNormalOwnerRef(p10) test.SetNormalOwnerRef(p11) // set pod anti affinity test.SetPodAntiAffinity(p1, "foo", "bar") test.SetPodAntiAffinity(p3, "foo", "bar") test.SetPodAntiAffinity(p4, "foo", "bar") test.SetPodAntiAffinity(p5, "foo1", "bar1") test.SetPodAntiAffinity(p6, "foo1", "bar1") test.SetPodAntiAffinity(p7, "foo", "bar") test.SetPodAntiAffinity(p9, "foo", "bar") test.SetPodAntiAffinity(p10, "foo", "bar") // set pod priority test.SetPodPriority(p5, 100) test.SetPodPriority(p6, 50) test.SetPodPriority(p7, 0) // Set pod node selectors p8.Spec.NodeSelector = map[string]string{ "datacenter": "west", } var uint1 uint = 1 var uint3 uint = 3 tests := []struct { description string maxPodsToEvictPerNode *uint maxNoOfPodsToEvictPerNamespace *uint pods []*v1.Pod expectedEvictedPodCount uint nodeFit bool nodes []*v1.Node }{ { description: "Maximum pods to evict - 0", pods: []*v1.Pod{p1, p2, p3, p4}, nodes: []*v1.Node{node1}, expectedEvictedPodCount: 3, }, { description: "Maximum pods to evict - 3", maxPodsToEvictPerNode: &uint3, pods: []*v1.Pod{p1, p2, p3, p4}, nodes: []*v1.Node{node1}, expectedEvictedPodCount: 3, }, { description: "Maximum pods to evict (maxPodsToEvictPerNamespace=3) - 3", maxNoOfPodsToEvictPerNamespace: &uint3, pods: []*v1.Pod{p1, p2, p3, p4}, nodes: []*v1.Node{node1}, expectedEvictedPodCount: 3, }, { description: "Evict only 1 pod after sorting", pods: []*v1.Pod{p5, p6, p7}, nodes: []*v1.Node{node1}, expectedEvictedPodCount: 1, }, { description: "Evicts pod that conflicts with critical pod (but does not evict critical pod)", maxPodsToEvictPerNode: &uint1, pods: []*v1.Pod{p1, nonEvictablePod}, nodes: []*v1.Node{node1}, expectedEvictedPodCount: 1, }, { description: "Evicts pod that conflicts with critical pod (but does not evict critical pod)", maxPodsToEvictPerNode: &uint1, pods: []*v1.Pod{p1, nonEvictablePod}, nodes: []*v1.Node{node1}, expectedEvictedPodCount: 1, }, { description: "Won't evict pods because node selectors don't match available nodes", maxPodsToEvictPerNode: &uint1, pods: []*v1.Pod{p8, nonEvictablePod}, nodes: []*v1.Node{node1, node2}, expectedEvictedPodCount: 0, nodeFit: true, }, { description: "Won't evict pods because only other node is not schedulable", maxPodsToEvictPerNode: &uint1, pods: []*v1.Pod{p8, nonEvictablePod}, nodes: []*v1.Node{node1, node3}, expectedEvictedPodCount: 0, nodeFit: true, }, { description: "No pod to evicted since all pod terminating", pods: []*v1.Pod{p9, p10}, nodes: []*v1.Node{node1}, expectedEvictedPodCount: 0, }, { description: "Won't evict pods because only other node doesn't have enough resources", maxPodsToEvictPerNode: &uint3, pods: []*v1.Pod{p1, p2, p3, p4}, nodes: []*v1.Node{node1, node4}, expectedEvictedPodCount: 0, nodeFit: true, }, { description: "Evict pod violating anti-affinity among different node (all pods have anti-affinity)", pods: []*v1.Pod{p1, p11}, nodes: []*v1.Node{node1, node5}, expectedEvictedPodCount: 1, nodeFit: false, }, } for _, test := range tests { t.Run(test.description, func(t *testing.T) { ctx, cancel := context.WithCancel(context.Background()) defer cancel() var objs []runtime.Object for _, node := range test.nodes { objs = append(objs, node) } for _, pod := range test.pods { objs = append(objs, pod) } fakeClient := fake.NewSimpleClientset(objs...) sharedInformerFactory := informers.NewSharedInformerFactory(fakeClient, 0) podInformer := sharedInformerFactory.Core().V1().Pods().Informer() getPodsAssignedToNode, err := podutil.BuildGetPodsAssignedToNodeFunc(podInformer) if err != nil { t.Errorf("Build get pods assigned to node function error: %v", err) } sharedInformerFactory.Start(ctx.Done()) sharedInformerFactory.WaitForCacheSync(ctx.Done()) eventRecorder := &events.FakeRecorder{} podEvictor := evictions.NewPodEvictor( fakeClient, eventRecorder, evictions.NewOptions(). WithMaxPodsToEvictPerNode(test.maxPodsToEvictPerNode). WithMaxPodsToEvictPerNamespace(test.maxNoOfPodsToEvictPerNamespace), ) defaultevictorArgs := &defaultevictor.DefaultEvictorArgs{ EvictLocalStoragePods: false, EvictSystemCriticalPods: false, IgnorePvcPods: false, EvictFailedBarePods: false, NodeFit: test.nodeFit, } evictorFilter, err := defaultevictor.New( defaultevictorArgs, &frameworkfake.HandleImpl{ ClientsetImpl: fakeClient, GetPodsAssignedToNodeFuncImpl: getPodsAssignedToNode, SharedInformerFactoryImpl: sharedInformerFactory, }, ) if err != nil { t.Fatalf("Unable to initialize the plugin: %v", err) } handle := &frameworkfake.HandleImpl{ ClientsetImpl: fakeClient, GetPodsAssignedToNodeFuncImpl: getPodsAssignedToNode, PodEvictorImpl: podEvictor, SharedInformerFactoryImpl: sharedInformerFactory, EvictorFilterImpl: evictorFilter.(frameworktypes.EvictorPlugin), } plugin, err := New( &RemovePodsViolatingInterPodAntiAffinityArgs{}, handle, ) plugin.(frameworktypes.DeschedulePlugin).Deschedule(ctx, test.nodes) podsEvicted := podEvictor.TotalEvicted() if podsEvicted != test.expectedEvictedPodCount { t.Errorf("Unexpected no of pods evicted: pods evicted: %d, expected: %d", podsEvicted, test.expectedEvictedPodCount) } }) } }