From fa874844a1527371502d76b29cb4822cb464cb13 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?vlc=E5=88=98=E8=AF=9A?= Date: Thu, 22 Sep 2022 14:10:57 +0800 Subject: [PATCH] RemovePodsHavingTooManyRestartsArgs defaulting --- .../defaults.go | 39 +++++++++++ .../defaults_test.go | 67 +++++++++++++++++++ .../removepodshavingtoomanyrestarts/doc.go | 16 +++++ .../register.go | 31 +++++++++ .../zz_generated.defaults.go | 40 +++++++++++ 5 files changed, 193 insertions(+) create mode 100644 pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults.go create mode 100644 pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults_test.go create mode 100644 pkg/framework/plugins/removepodshavingtoomanyrestarts/doc.go create mode 100644 pkg/framework/plugins/removepodshavingtoomanyrestarts/register.go create mode 100644 pkg/framework/plugins/removepodshavingtoomanyrestarts/zz_generated.defaults.go diff --git a/pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults.go b/pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults.go new file mode 100644 index 000000000..388232b0a --- /dev/null +++ b/pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults.go @@ -0,0 +1,39 @@ +/* +Copyright 2022 The Kubernetes Authors. +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package removepodshavingtoomanyrestarts + +import ( + "k8s.io/apimachinery/pkg/runtime" +) + +func addDefaultingFuncs(scheme *runtime.Scheme) error { + return RegisterDefaults(scheme) +} + +// SetDefaults_RemovePodsHavingTooManyRestartsArgs +// TODO: the final default values would be discussed in community +func SetDefaults_RemovePodsHavingTooManyRestartsArgs(obj *RemovePodsHavingTooManyRestartsArgs) { + if obj.Namespaces == nil { + obj.Namespaces = nil + } + if obj.LabelSelector == nil { + obj.LabelSelector = nil + } + if obj.PodRestartThreshold == 0 { + obj.PodRestartThreshold = 0 + } + if obj.IncludingInitContainers == false { + obj.IncludingInitContainers = false + } +} diff --git a/pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults_test.go b/pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults_test.go new file mode 100644 index 000000000..25cd3f5dc --- /dev/null +++ b/pkg/framework/plugins/removepodshavingtoomanyrestarts/defaults_test.go @@ -0,0 +1,67 @@ +/* +Copyright 2022 The Kubernetes Authors. +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package removepodshavingtoomanyrestarts + +import ( + "github.com/google/go-cmp/cmp" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + "k8s.io/apimachinery/pkg/runtime" + utilruntime "k8s.io/apimachinery/pkg/util/runtime" + "sigs.k8s.io/descheduler/pkg/api" + "testing" +) + +func TestSetDefaults_RemovePodsHavingTooManyRestartsArgs(t *testing.T) { + tests := []struct { + name string + in runtime.Object + want runtime.Object + }{ + { + name: "RemovePodsHavingTooManyRestartsArgs empty", + in: &RemovePodsHavingTooManyRestartsArgs{}, + want: &RemovePodsHavingTooManyRestartsArgs{ + Namespaces: nil, + LabelSelector: nil, + PodRestartThreshold: 0, + IncludingInitContainers: false, + }, + }, + { + name: "RemovePodsHavingTooManyRestartsArgs with value", + in: &RemovePodsHavingTooManyRestartsArgs{ + Namespaces: &api.Namespaces{}, + LabelSelector: &metav1.LabelSelector{}, + PodRestartThreshold: 10, + IncludingInitContainers: true, + }, + want: &RemovePodsHavingTooManyRestartsArgs{ + Namespaces: &api.Namespaces{}, + LabelSelector: &metav1.LabelSelector{}, + PodRestartThreshold: 10, + IncludingInitContainers: true, + }, + }, + } + for _, tc := range tests { + scheme := runtime.NewScheme() + utilruntime.Must(AddToScheme(scheme)) + t.Run(tc.name, func(t *testing.T) { + scheme.Default(tc.in) + if diff := cmp.Diff(tc.in, tc.want); diff != "" { + t.Errorf("Got unexpected defaults (-want, +got):\n%s", diff) + } + }) + } +} diff --git a/pkg/framework/plugins/removepodshavingtoomanyrestarts/doc.go b/pkg/framework/plugins/removepodshavingtoomanyrestarts/doc.go new file mode 100644 index 000000000..954422b2d --- /dev/null +++ b/pkg/framework/plugins/removepodshavingtoomanyrestarts/doc.go @@ -0,0 +1,16 @@ +/* +Copyright 2022 The Kubernetes Authors. +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +// +k8s:defaulter-gen=TypeMeta + +package removepodshavingtoomanyrestarts diff --git a/pkg/framework/plugins/removepodshavingtoomanyrestarts/register.go b/pkg/framework/plugins/removepodshavingtoomanyrestarts/register.go new file mode 100644 index 000000000..a4033889c --- /dev/null +++ b/pkg/framework/plugins/removepodshavingtoomanyrestarts/register.go @@ -0,0 +1,31 @@ +/* +Copyright 2022 The Kubernetes Authors. +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + http://www.apache.org/licenses/LICENSE-2.0 +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +package removepodshavingtoomanyrestarts + +import ( + "k8s.io/apimachinery/pkg/runtime" +) + +var ( + SchemeBuilder = runtime.NewSchemeBuilder() + localSchemeBuilder = &SchemeBuilder + AddToScheme = localSchemeBuilder.AddToScheme +) + +func init() { + // We only register manually written functions here. The registration of the + // generated functions takes place in the generated files. The separation + // makes the code compile even when the generated files are missing. + localSchemeBuilder.Register(addDefaultingFuncs) +} diff --git a/pkg/framework/plugins/removepodshavingtoomanyrestarts/zz_generated.defaults.go b/pkg/framework/plugins/removepodshavingtoomanyrestarts/zz_generated.defaults.go new file mode 100644 index 000000000..7705a78a9 --- /dev/null +++ b/pkg/framework/plugins/removepodshavingtoomanyrestarts/zz_generated.defaults.go @@ -0,0 +1,40 @@ +//go:build !ignore_autogenerated +// +build !ignore_autogenerated + +/* +Copyright 2022 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +// Code generated by defaulter-gen. DO NOT EDIT. + +package removepodshavingtoomanyrestarts + +import ( + runtime "k8s.io/apimachinery/pkg/runtime" +) + +// RegisterDefaults adds defaulters functions to the given scheme. +// Public to allow building arbitrary schemes. +// All generated defaulters are covering - they call all nested defaulters. +func RegisterDefaults(scheme *runtime.Scheme) error { + scheme.AddTypeDefaultingFunc(&RemovePodsHavingTooManyRestartsArgs{}, func(obj interface{}) { + SetObjectDefaults_RemovePodsHavingTooManyRestartsArgs(obj.(*RemovePodsHavingTooManyRestartsArgs)) + }) + return nil +} + +func SetObjectDefaults_RemovePodsHavingTooManyRestartsArgs(in *RemovePodsHavingTooManyRestartsArgs) { + SetDefaults_RemovePodsHavingTooManyRestartsArgs(in) +}