From ec4c5bed5dfb8880a34480173f951cdc03c70ae5 Mon Sep 17 00:00:00 2001 From: Mike Dame Date: Mon, 10 Aug 2020 09:36:34 -0400 Subject: [PATCH] Add check for ownerref length in DuplicatePods strategy This fixes a panic that occurs if a pod has no ownerrefs later on in the strategy. If a pod has no ownerrefs, there's nothing for us to do with it. --- pkg/descheduler/strategies/duplicates.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/descheduler/strategies/duplicates.go b/pkg/descheduler/strategies/duplicates.go index d14582352..4d485e3c8 100644 --- a/pkg/descheduler/strategies/duplicates.go +++ b/pkg/descheduler/strategies/duplicates.go @@ -69,7 +69,7 @@ func RemoveDuplicatePods( duplicateKeysMap := map[string][][]string{} for _, pod := range pods { ownerRefList := podutil.OwnerRef(pod) - if hasExcludedOwnerRefKind(ownerRefList, strategy) { + if hasExcludedOwnerRefKind(ownerRefList, strategy) || len(ownerRefList) == 0 { continue } podContainerKeys := make([]string, 0, len(ownerRefList)*len(pod.Spec.Containers))