From 97220188479083b4561fe6f5fde2a5224a90cf1e Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 12:55:59 +0100 Subject: [PATCH 01/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 70a4d9cde..854394f9a 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -39,16 +39,17 @@ func TestPodLifeTime(t *testing.T) { olderPodCreationTime := metav1.NewTime(time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC)) newerPodCreationTime := metav1.NewTime(time.Now()) + ownerRef1 := test.GetReplicaSetOwnerRefList() + // Setup pods, one should be evicted - p1 := test.BuildTestPod("p1", 100, 0, node1.Name, nil) - p1.Namespace = "dev" - p1.ObjectMeta.CreationTimestamp = newerPodCreationTime + p1 := test.BuildTestPod("p1", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = newerPodCreationTime + pod.ObjectMeta.OwnerReferences = ownerRef1 + }) p2 := test.BuildTestPod("p2", 100, 0, node1.Name, nil) p2.Namespace = "dev" p2.ObjectMeta.CreationTimestamp = olderPodCreationTime - - ownerRef1 := test.GetReplicaSetOwnerRefList() - p1.ObjectMeta.OwnerReferences = ownerRef1 p2.ObjectMeta.OwnerReferences = ownerRef1 // Setup pods, zero should be evicted From 0c80f3689d2fa9b46c7360ffad1876506a293202 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 12:59:59 +0100 Subject: [PATCH 02/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- pkg/framework/plugins/podlifetime/pod_lifetime_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 854394f9a..fd8b2212f 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -47,10 +47,11 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.CreationTimestamp = newerPodCreationTime pod.ObjectMeta.OwnerReferences = ownerRef1 }) - p2 := test.BuildTestPod("p2", 100, 0, node1.Name, nil) - p2.Namespace = "dev" - p2.ObjectMeta.CreationTimestamp = olderPodCreationTime - p2.ObjectMeta.OwnerReferences = ownerRef1 + p2 := test.BuildTestPod("p2", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.ObjectMeta.OwnerReferences = ownerRef1 + }) // Setup pods, zero should be evicted p3 := test.BuildTestPod("p3", 100, 0, node1.Name, nil) From 31af0d8223ea97953bef9c4125ea3e8bf4eec39a Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:02:58 +0100 Subject: [PATCH 03/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index fd8b2212f..47c4fad03 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -53,16 +53,17 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.OwnerReferences = ownerRef1 }) + ownerRef2 := test.GetReplicaSetOwnerRefList() + // Setup pods, zero should be evicted - p3 := test.BuildTestPod("p3", 100, 0, node1.Name, nil) - p3.Namespace = "dev" - p3.ObjectMeta.CreationTimestamp = newerPodCreationTime + p3 := test.BuildTestPod("p3", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = newerPodCreationTime + pod.ObjectMeta.OwnerReferences = ownerRef2 + }) p4 := test.BuildTestPod("p4", 100, 0, node1.Name, nil) p4.Namespace = "dev" p4.ObjectMeta.CreationTimestamp = newerPodCreationTime - - ownerRef2 := test.GetReplicaSetOwnerRefList() - p3.ObjectMeta.OwnerReferences = ownerRef2 p4.ObjectMeta.OwnerReferences = ownerRef2 // Setup pods, one should be evicted From 6ffc7e3975faf9117524853ffe471561ca1b6d2b Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:03:31 +0100 Subject: [PATCH 04/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- pkg/framework/plugins/podlifetime/pod_lifetime_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 47c4fad03..f92007a65 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -61,10 +61,11 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.CreationTimestamp = newerPodCreationTime pod.ObjectMeta.OwnerReferences = ownerRef2 }) - p4 := test.BuildTestPod("p4", 100, 0, node1.Name, nil) - p4.Namespace = "dev" - p4.ObjectMeta.CreationTimestamp = newerPodCreationTime - p4.ObjectMeta.OwnerReferences = ownerRef2 + p4 := test.BuildTestPod("p4", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = newerPodCreationTime + pod.ObjectMeta.OwnerReferences = ownerRef2 + }) // Setup pods, one should be evicted p5 := test.BuildTestPod("p5", 100, 0, node1.Name, nil) From 769b4fe34ac8b4f306dfa7a4c770e7529cc7875d Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:04:24 +0100 Subject: [PATCH 05/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index f92007a65..6f3986e5d 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -67,16 +67,17 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.OwnerReferences = ownerRef2 }) + ownerRef3 := test.GetReplicaSetOwnerRefList() + // Setup pods, one should be evicted - p5 := test.BuildTestPod("p5", 100, 0, node1.Name, nil) - p5.Namespace = "dev" - p5.ObjectMeta.CreationTimestamp = newerPodCreationTime + p5 := test.BuildTestPod("p5", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = newerPodCreationTime + pod.ObjectMeta.OwnerReferences = ownerRef3 + }) p6 := test.BuildTestPod("p6", 100, 0, node1.Name, nil) p6.Namespace = "dev" p6.ObjectMeta.CreationTimestamp = metav1.NewTime(time.Now().Add(-time.Second * 605)) - - ownerRef3 := test.GetReplicaSetOwnerRefList() - p5.ObjectMeta.OwnerReferences = ownerRef3 p6.ObjectMeta.OwnerReferences = ownerRef3 // Setup pods, zero should be evicted From 18f61b5e64e2843cb64da92ad85ac7842dee02fe Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:06:00 +0100 Subject: [PATCH 06/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- pkg/framework/plugins/podlifetime/pod_lifetime_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 6f3986e5d..951087e2f 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -75,10 +75,11 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.CreationTimestamp = newerPodCreationTime pod.ObjectMeta.OwnerReferences = ownerRef3 }) - p6 := test.BuildTestPod("p6", 100, 0, node1.Name, nil) - p6.Namespace = "dev" - p6.ObjectMeta.CreationTimestamp = metav1.NewTime(time.Now().Add(-time.Second * 605)) - p6.ObjectMeta.OwnerReferences = ownerRef3 + p6 := test.BuildTestPod("p6", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = metav1.NewTime(time.Now().Add(-time.Second * 605)) + pod.ObjectMeta.OwnerReferences = ownerRef3 + }) // Setup pods, zero should be evicted p7 := test.BuildTestPod("p7", 100, 0, node1.Name, nil) From 7bfd4088ce1168cc74cfccec417faa2296fa1da1 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:07:07 +0100 Subject: [PATCH 07/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- pkg/framework/plugins/podlifetime/pod_lifetime_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 951087e2f..ff5ed2c39 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -82,9 +82,10 @@ func TestPodLifeTime(t *testing.T) { }) // Setup pods, zero should be evicted - p7 := test.BuildTestPod("p7", 100, 0, node1.Name, nil) - p7.Namespace = "dev" - p7.ObjectMeta.CreationTimestamp = newerPodCreationTime + p7 := test.BuildTestPod("p7", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = newerPodCreationTime + }) p8 := test.BuildTestPod("p8", 100, 0, node1.Name, nil) p8.Namespace = "dev" p8.ObjectMeta.CreationTimestamp = metav1.NewTime(time.Now().Add(-time.Second * 595)) From fbdf86fdfd9b33736cdc088051e3165c9a427a31 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:26:41 +0100 Subject: [PATCH 08/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- pkg/framework/plugins/podlifetime/pod_lifetime_test.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index ff5ed2c39..34c5f46ef 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -86,9 +86,10 @@ func TestPodLifeTime(t *testing.T) { pod.Namespace = "dev" pod.ObjectMeta.CreationTimestamp = newerPodCreationTime }) - p8 := test.BuildTestPod("p8", 100, 0, node1.Name, nil) - p8.Namespace = "dev" - p8.ObjectMeta.CreationTimestamp = metav1.NewTime(time.Now().Add(-time.Second * 595)) + p8 := test.BuildTestPod("p8", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = metav1.NewTime(time.Now().Add(-time.Second * 595)) + }) // Setup two old pods with different status phases p9 := test.BuildTestPod("p9", 100, 0, node1.Name, nil) From cece2ee3cc846495e885c3f0999634a1ea716f8e Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:27:45 +0100 Subject: [PATCH 09/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 34c5f46ef..7863a41e6 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -92,16 +92,16 @@ func TestPodLifeTime(t *testing.T) { }) // Setup two old pods with different status phases - p9 := test.BuildTestPod("p9", 100, 0, node1.Name, nil) - p9.Namespace = "dev" - p9.ObjectMeta.CreationTimestamp = olderPodCreationTime + p9 := test.BuildTestPod("p9", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.Status.Phase = "Pending" + pod.ObjectMeta.OwnerReferences = ownerRef1 + }) p10 := test.BuildTestPod("p10", 100, 0, node1.Name, nil) p10.Namespace = "dev" p10.ObjectMeta.CreationTimestamp = olderPodCreationTime - - p9.Status.Phase = "Pending" p10.Status.Phase = "Running" - p9.ObjectMeta.OwnerReferences = ownerRef1 p10.ObjectMeta.OwnerReferences = ownerRef1 p11 := test.BuildTestPod("p11", 100, 0, node1.Name, func(pod *v1.Pod) { From ee40f7ff3028fb51d6db559035226b6dbb8c6a3e Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:51:42 +0100 Subject: [PATCH 10/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 7863a41e6..7ca53dfdc 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -98,11 +98,12 @@ func TestPodLifeTime(t *testing.T) { pod.Status.Phase = "Pending" pod.ObjectMeta.OwnerReferences = ownerRef1 }) - p10 := test.BuildTestPod("p10", 100, 0, node1.Name, nil) - p10.Namespace = "dev" - p10.ObjectMeta.CreationTimestamp = olderPodCreationTime - p10.Status.Phase = "Running" - p10.ObjectMeta.OwnerReferences = ownerRef1 + p10 := test.BuildTestPod("p10", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.Status.Phase = "Running" + pod.ObjectMeta.OwnerReferences = ownerRef1 + }) p11 := test.BuildTestPod("p11", 100, 0, node1.Name, func(pod *v1.Pod) { pod.Spec.Volumes = []v1.Volume{ From 34540c3c95b1f0198b7dd93afe231fcf04baad32 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:54:37 +0100 Subject: [PATCH 11/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 7ca53dfdc..148d07f38 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -119,16 +119,16 @@ func TestPodLifeTime(t *testing.T) { }) // Setup two old pods with different labels - p12 := test.BuildTestPod("p12", 100, 0, node1.Name, nil) - p12.Namespace = "dev" - p12.ObjectMeta.CreationTimestamp = olderPodCreationTime + p12 := test.BuildTestPod("p12", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.ObjectMeta.Labels = map[string]string{"foo": "bar"} + pod.ObjectMeta.OwnerReferences = ownerRef1 + }) p13 := test.BuildTestPod("p13", 100, 0, node1.Name, nil) p13.Namespace = "dev" p13.ObjectMeta.CreationTimestamp = olderPodCreationTime - - p12.ObjectMeta.Labels = map[string]string{"foo": "bar"} p13.ObjectMeta.Labels = map[string]string{"foo": "bar1"} - p12.ObjectMeta.OwnerReferences = ownerRef1 p13.ObjectMeta.OwnerReferences = ownerRef1 p14 := test.BuildTestPod("p14", 100, 0, node1.Name, nil) From ff6363692c7c45f28c9105985e981ed085f5f476 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:56:05 +0100 Subject: [PATCH 12/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 148d07f38..4c05e3ebe 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -125,11 +125,12 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.Labels = map[string]string{"foo": "bar"} pod.ObjectMeta.OwnerReferences = ownerRef1 }) - p13 := test.BuildTestPod("p13", 100, 0, node1.Name, nil) - p13.Namespace = "dev" - p13.ObjectMeta.CreationTimestamp = olderPodCreationTime - p13.ObjectMeta.Labels = map[string]string{"foo": "bar1"} - p13.ObjectMeta.OwnerReferences = ownerRef1 + p13 := test.BuildTestPod("p13", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.ObjectMeta.Labels = map[string]string{"foo": "bar1"} + pod.ObjectMeta.OwnerReferences = ownerRef1 + }) p14 := test.BuildTestPod("p14", 100, 0, node1.Name, nil) p15 := test.BuildTestPod("p15", 100, 0, node1.Name, nil) From c02779b6a5a5944049f5c203d5df9381b2dad4b1 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:57:34 +0100 Subject: [PATCH 13/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 4c05e3ebe..ec3299fec 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -132,15 +132,16 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.OwnerReferences = ownerRef1 }) - p14 := test.BuildTestPod("p14", 100, 0, node1.Name, nil) + p14 := test.BuildTestPod("p14", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.ObjectMeta.OwnerReferences = ownerRef1 + pod.DeletionTimestamp = &metav1.Time{} + }) p15 := test.BuildTestPod("p15", 100, 0, node1.Name, nil) - p14.Namespace = "dev" p15.Namespace = "dev" - p14.ObjectMeta.CreationTimestamp = olderPodCreationTime p15.ObjectMeta.CreationTimestamp = olderPodCreationTime - p14.ObjectMeta.OwnerReferences = ownerRef1 p15.ObjectMeta.OwnerReferences = ownerRef1 - p14.DeletionTimestamp = &metav1.Time{} p15.DeletionTimestamp = &metav1.Time{} p16 := test.BuildTestPod("p16", 100, 0, node1.Name, nil) From 1a61470e81e5997b3396aa279a801b5d475698b3 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 13:58:33 +0100 Subject: [PATCH 14/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index ec3299fec..935be85a8 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -138,11 +138,12 @@ func TestPodLifeTime(t *testing.T) { pod.ObjectMeta.OwnerReferences = ownerRef1 pod.DeletionTimestamp = &metav1.Time{} }) - p15 := test.BuildTestPod("p15", 100, 0, node1.Name, nil) - p15.Namespace = "dev" - p15.ObjectMeta.CreationTimestamp = olderPodCreationTime - p15.ObjectMeta.OwnerReferences = ownerRef1 - p15.DeletionTimestamp = &metav1.Time{} + p15 := test.BuildTestPod("p15", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.ObjectMeta.OwnerReferences = ownerRef1 + pod.DeletionTimestamp = &metav1.Time{} + }) p16 := test.BuildTestPod("p16", 100, 0, node1.Name, nil) p16.Namespace = "dev" From 16b9311e9e342eebf659804fc00ecb3f549809d8 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 14:00:12 +0100 Subject: [PATCH 15/15] refactor(TestPodLifeTime): have a pod fully created through BuildTestPod without any edits --- .../plugins/podlifetime/pod_lifetime_test.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 935be85a8..930918f5a 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -145,11 +145,12 @@ func TestPodLifeTime(t *testing.T) { pod.DeletionTimestamp = &metav1.Time{} }) - p16 := test.BuildTestPod("p16", 100, 0, node1.Name, nil) - p16.Namespace = "dev" - p16.ObjectMeta.CreationTimestamp = olderPodCreationTime - p16.Status.Phase = v1.PodUnknown - p16.ObjectMeta.OwnerReferences = ownerRef1 + p16 := test.BuildTestPod("p16", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "dev" + pod.ObjectMeta.CreationTimestamp = olderPodCreationTime + pod.Status.Phase = v1.PodUnknown + pod.ObjectMeta.OwnerReferences = ownerRef1 + }) var maxLifeTime uint = 600 testCases := []struct {