Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-26 05:14:13 +01:00
Code Packages Releases Activity

refactor(TestDefaultEvictor): add setNodeLabel helper function

Browse Source
This commit is contained in:
Jan Chaloupka
2025-12-20 14:08:11 +01:00
parent 3bb4529c34
commit dfd2b95d2d
1 changed files with 18 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
pkg/framework/plugins/defaultevictor/defaultevictor_test.go
View File

@@ -87,6 +87,12 @@ func TestDefaultEvictorPreEvictionFilter(t *testing.T) {
} }
} }
setNodeLabel := func(node *v1.Node) {
node.ObjectMeta.Labels = map[string]string{
nodeLabelKey: nodeLabelValue,
}
}
testCases := []testCase{ testCases := []testCase{
{ {
description: "Pod with no tolerations running on normal node, all other nodes tainted", description: "Pod with no tolerations running on normal node, all other nodes tainted",
@@ -129,16 +135,8 @@ func TestDefaultEvictorPreEvictionFilter(t *testing.T) {
}), }),
}, },
nodes: []*v1.Node{ nodes: []*v1.Node{
buildTestNode("node2", func(node *v1.Node) { buildTestNode("node2", setNodeLabel),
node.ObjectMeta.Labels = map[string]string{ buildTestNode("node3", setNodeLabel),
nodeLabelKey: nodeLabelValue,
}
}),
buildTestNode("node3", func(node *v1.Node) {
node.ObjectMeta.Labels = map[string]string{
nodeLabelKey: nodeLabelValue,
}
}),
}, },
nodeFit: true, nodeFit: true,
}, { }, {
@@ -152,16 +150,8 @@ func TestDefaultEvictorPreEvictionFilter(t *testing.T) {
}), }),
}, },
nodes: []*v1.Node{ nodes: []*v1.Node{
buildTestNode("node2", func(node *v1.Node) { buildTestNode("node2", setNodeLabel),
node.ObjectMeta.Labels = map[string]string{ buildTestNode("node3", setNodeLabel),
nodeLabelKey: nodeLabelValue,
}
}),
buildTestNode("node3", func(node *v1.Node) {
node.ObjectMeta.Labels = map[string]string{
nodeLabelKey: nodeLabelValue,
}
}),
}, },
nodeFit: true, nodeFit: true,
result: true, result: true,
@@ -176,16 +166,8 @@ func TestDefaultEvictorPreEvictionFilter(t *testing.T) {
}), }),
}, },
nodes: []*v1.Node{ nodes: []*v1.Node{
test.BuildTestNode("node2-TEST", 10, 16, 10, func(node *v1.Node) { test.BuildTestNode("node2-TEST", 10, 16, 10, setNodeLabel),
node.ObjectMeta.Labels = map[string]string{ test.BuildTestNode("node3-TEST", 10, 16, 10, setNodeLabel),
nodeLabelKey: nodeLabelValue,
}
}),
test.BuildTestNode("node3-TEST", 10, 16, 10, func(node *v1.Node) {
node.ObjectMeta.Labels = map[string]string{
nodeLabelKey: nodeLabelValue,
}
}),
}, },
nodeFit: true, nodeFit: true,
}, { }, {
@@ -209,16 +191,8 @@ func TestDefaultEvictorPreEvictionFilter(t *testing.T) {
}), }),
}, },
nodes: []*v1.Node{ nodes: []*v1.Node{
test.BuildTestNode("node2", 100, 16, 10, func(node *v1.Node) { test.BuildTestNode("node2", 100, 16, 10, setNodeLabel),
node.ObjectMeta.Labels = map[string]string{ test.BuildTestNode("node3", 100, 20, 10, setNodeLabel),
nodeLabelKey: nodeLabelValue,
}
}),
test.BuildTestNode("node3", 100, 20, 10, func(node *v1.Node) {
node.ObjectMeta.Labels = map[string]string{
nodeLabelKey: nodeLabelValue,
}
}),
}, },
nodeFit: true, nodeFit: true,
result: true, result: true,
@@ -243,16 +217,8 @@ func TestDefaultEvictorPreEvictionFilter(t *testing.T) {
}), }),
}, },
nodes: []*v1.Node{ nodes: []*v1.Node{
test.BuildTestNode("node2", 100, 16, 10, func(node *v1.Node) { test.BuildTestNode("node2", 100, 16, 10, setNodeLabel),
node.ObjectMeta.Labels = map[string]string{ test.BuildTestNode("node3", 100, 16, 10, setNodeLabel),
nodeLabelKey: nodeLabelValue,
}
}),
test.BuildTestNode("node3", 100, 16, 10, func(node *v1.Node) {
node.ObjectMeta.Labels = map[string]string{
nodeLabelKey: nodeLabelValue,
}
}),
}, },
nodeFit: true, nodeFit: true,
}, { }, {
@@ -266,16 +232,8 @@ func TestDefaultEvictorPreEvictionFilter(t *testing.T) {
}), }),
}, },
nodes: []*v1.Node{ nodes: []*v1.Node{
buildTestNode("node2", func(node *v1.Node) { buildTestNode("node2", setNodeLabel),
node.ObjectMeta.Labels = map[string]string{ buildTestNode("node3", setNodeLabel),
nodeLabelKey: nodeLabelValue,
}
}),
buildTestNode("node3", func(node *v1.Node) {
node.ObjectMeta.Labels = map[string]string{
nodeLabelKey: nodeLabelValue,
}
}),
}, },
result: true, result: true,
}, },