From ca5781827a66f5c0912f4a31b6563dd82cf4bc0e Mon Sep 17 00:00:00 2001 From: Abirdcfly Date: Wed, 9 Aug 2023 21:36:53 +0800 Subject: [PATCH] fix: descheduler_loop_duration_seconds has wrong value Signed-off-by: Abirdcfly --- pkg/descheduler/descheduler.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/descheduler/descheduler.go b/pkg/descheduler/descheduler.go index 905d0d826..8ae974670 100644 --- a/pkg/descheduler/descheduler.go +++ b/pkg/descheduler/descheduler.go @@ -112,8 +112,9 @@ func (d *descheduler) runDeschedulerLoop(ctx context.Context, nodes []*v1.Node) var span trace.Span ctx, span = tracing.Tracer().Start(ctx, "runDeschedulerLoop") defer span.End() - loopStartDuration := time.Now() - defer metrics.DeschedulerLoopDuration.With(map[string]string{}).Observe(time.Since(loopStartDuration).Seconds()) + defer func(loopStartDuration time.Time) { + metrics.DeschedulerLoopDuration.With(map[string]string{}).Observe(time.Since(loopStartDuration).Seconds()) + }(time.Now()) // if len is still <= 1 error out if len(nodes) <= 1 {