From c1cd3ae7942b9226148064d7c13ff64ce4c88514 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Mon, 15 Dec 2025 18:01:25 +0100 Subject: [PATCH] refactor(node_taint_test): inline p3 --- .../node_taint_test.go | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go index b4fa88a5d..62490c424 100644 --- a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go +++ b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go @@ -154,7 +154,6 @@ func withKubeSystemCriticalPod(pod *v1.Pod) { } func TestDeletePodsViolatingNodeTaints(t *testing.T) { - p3 := buildTestPodWithNormalOwnerRef("p3", nodeName1, withTestTaintToleration1) p4 := buildTestPodWithNormalOwnerRef("p4", nodeName1, withTestTaintXToleration1) p5 := buildTestPodWithNormalOwnerRef("p5", nodeName1, nil) p6 := buildTestPodWithNormalOwnerRef("p6", nodeName1, nil) @@ -210,7 +209,7 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { pods: []*v1.Pod{ buildTestPodWithNormalOwnerRef("p1", nodeName1, withTestTaintToleration1), buildTestPodWithNormalOwnerRef("p2", nodeName1, nil), - p3, + buildTestPodWithNormalOwnerRef("p3", nodeName1, withTestTaintToleration1), }, nodes: []*v1.Node{ buildTestNode(nodeName1, withTestTaint1), @@ -221,7 +220,7 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { description: "Pods with tolerations but not tolerating node taint should be evicted", pods: []*v1.Pod{ buildTestPodWithNormalOwnerRef("p1", nodeName1, withTestTaintToleration1), - p3, + buildTestPodWithNormalOwnerRef("p3", nodeName1, withTestTaintToleration1), p4, }, nodes: []*v1.Node{ @@ -327,7 +326,7 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { pods: []*v1.Pod{ buildTestPodWithNormalOwnerRef("p1", nodeName1, withTestTaintToleration1), buildTestPodWithNormalOwnerRef("p2", nodeName1, nil), - p3, + buildTestPodWithNormalOwnerRef("p3", nodeName1, withTestTaintToleration1), }, nodes: []*v1.Node{ buildTestNode(nodeName1, withTestTaint1), @@ -340,7 +339,7 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { description: "Pod p12 doesn't tolerate taint on it's node, but other nodes don't match it's selector", pods: []*v1.Pod{ buildTestPodWithNormalOwnerRef("p1", nodeName1, withTestTaintToleration1), - p3, + buildTestPodWithNormalOwnerRef("p3", nodeName1, withTestTaintToleration1), p12, }, nodes: []*v1.Node{ @@ -355,7 +354,7 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { pods: []*v1.Pod{ buildTestPodWithNormalOwnerRef("p1", nodeName1, withTestTaintToleration1), buildTestPodWithNormalOwnerRef("p2", nodeName1, nil), - p3, + buildTestPodWithNormalOwnerRef("p3", nodeName1, withTestTaintToleration1), }, nodes: []*v1.Node{ buildTestNode(nodeName1, withTestTaint1), @@ -459,7 +458,7 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { pods: []*v1.Pod{ buildTestPodWithNormalOwnerRef("p1", nodeName1, withTestTaintToleration1), buildTestPodWithNormalOwnerRef("p2", nodeName1, nil), - p3, + buildTestPodWithNormalOwnerRef("p3", nodeName1, withTestTaintToleration1), }, nodes: []*v1.Node{ buildTestNode(nodeName1, withTestTaint1),