From b472549cf665bc298f8dfd05731c48c1dedd2205 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Mon, 15 Dec 2025 17:54:53 +0100 Subject: [PATCH] refactor(node_taint_test): add withKubeSystemCriticalPod helper --- .../removepodsviolatingnodetaints/node_taint_test.go | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go index c4e67a999..4697d9f56 100644 --- a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go +++ b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go @@ -148,6 +148,11 @@ func withLocalStorageVolume(pod *v1.Pod) { } } +func withKubeSystemCriticalPod(pod *v1.Pod) { + pod.Namespace = "kube-system" + test.SetPodPriority(pod, utils.SystemCriticalPriority) +} + func TestDeletePodsViolatingNodeTaints(t *testing.T) { p1 := buildTestPodWithNormalOwnerRef("p1", nodeName1, withTestTaintToleration1) p2 := buildTestPodWithNormalOwnerRef("p2", nodeName1, nil) @@ -155,10 +160,7 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { p4 := buildTestPodWithNormalOwnerRef("p4", nodeName1, withTestTaintXToleration1) p5 := buildTestPodWithNormalOwnerRef("p5", nodeName1, nil) p6 := buildTestPodWithNormalOwnerRef("p6", nodeName1, nil) - p7 := buildTestPodWithNormalOwnerRef("p7", nodeName2, func(pod *v1.Pod) { - pod.Namespace = "kube-system" - test.SetPodPriority(pod, utils.SystemCriticalPriority) - }) + p7 := buildTestPodWithNormalOwnerRef("p7", nodeName2, withKubeSystemCriticalPod) p8 := buildTestPod("p8", nodeName2, test.SetDSOwnerRef) p9 := buildTestPodWithNormalOwnerRef("p9", nodeName2, withLocalStorageVolume) p10 := buildTestPodWithNormalOwnerRef("p10", nodeName2, test.SetMirrorPodAnnotation)