From 9eb4c350d81982b1d5931820364c721074e73369 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?vlc=E5=88=98=E8=AF=9A?= Date: Mon, 19 Sep 2022 15:50:25 +0800 Subject: [PATCH] e2e_test fixing --- test/e2e/e2e_test.go | 5 ++--- test/e2e/e2e_toomanyrestarts_test.go | 7 +++---- test/e2e/e2e_topologyspreadconstraint_test.go | 3 +-- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/test/e2e/e2e_test.go b/test/e2e/e2e_test.go index 770aefa73..7a785aafa 100644 --- a/test/e2e/e2e_test.go +++ b/test/e2e/e2e_test.go @@ -41,7 +41,6 @@ import ( "sigs.k8s.io/descheduler/cmd/descheduler/app/options" "sigs.k8s.io/descheduler/pkg/api" deschedulerapi "sigs.k8s.io/descheduler/pkg/api" - "sigs.k8s.io/descheduler/pkg/apis/componentconfig" "sigs.k8s.io/descheduler/pkg/descheduler" "sigs.k8s.io/descheduler/pkg/descheduler/client" "sigs.k8s.io/descheduler/pkg/descheduler/evictions" @@ -224,7 +223,7 @@ func runPodLifetimePlugin( maxPodLifeTimeSeconds := uint(1) - plugin, err := podlifetime.New(&componentconfig.PodLifeTimeArgs{ + plugin, err := podlifetime.New(&podlifetime.PodLifeTimeArgs{ MaxPodLifeTimeSeconds: &maxPodLifeTimeSeconds, LabelSelector: labelSelector, Namespaces: namespaces, @@ -393,7 +392,7 @@ func TestLowNodeUtilization(t *testing.T) { SharedInformerFactoryImpl: sharedInformerFactory, } - plugin, err := nodeutilization.NewLowNodeUtilization(&componentconfig.LowNodeUtilizationArgs{ + plugin, err := nodeutilization.NewLowNodeUtilization(&nodeutilization.LowNodeUtilizationArgs{ Thresholds: api.ResourceThresholds{ v1.ResourceCPU: 70, }, diff --git a/test/e2e/e2e_toomanyrestarts_test.go b/test/e2e/e2e_toomanyrestarts_test.go index 2e436ba03..2765f4f4a 100644 --- a/test/e2e/e2e_toomanyrestarts_test.go +++ b/test/e2e/e2e_toomanyrestarts_test.go @@ -31,7 +31,6 @@ import ( "k8s.io/client-go/tools/events" "k8s.io/utils/pointer" - "sigs.k8s.io/descheduler/pkg/apis/componentconfig" "sigs.k8s.io/descheduler/pkg/descheduler/evictions" eutils "sigs.k8s.io/descheduler/pkg/descheduler/evictions/utils" "sigs.k8s.io/descheduler/pkg/framework" @@ -114,8 +113,8 @@ func TestTooManyRestarts(t *testing.T) { createRemovePodsHavingTooManyRestartsAgrs := func( podRestartThresholds int32, includingInitContainers bool, - ) componentconfig.RemovePodsHavingTooManyRestartsArgs { - return componentconfig.RemovePodsHavingTooManyRestartsArgs{ + ) removepodshavingtoomanyrestarts.RemovePodsHavingTooManyRestartsArgs { + return removepodshavingtoomanyrestarts.RemovePodsHavingTooManyRestartsArgs{ PodRestartThreshold: podRestartThresholds, IncludingInitContainers: includingInitContainers, } @@ -123,7 +122,7 @@ func TestTooManyRestarts(t *testing.T) { tests := []struct { name string - args componentconfig.RemovePodsHavingTooManyRestartsArgs + args removepodshavingtoomanyrestarts.RemovePodsHavingTooManyRestartsArgs expectedEvictedPodCount uint }{ { diff --git a/test/e2e/e2e_topologyspreadconstraint_test.go b/test/e2e/e2e_topologyspreadconstraint_test.go index e436006a2..cf7147edc 100644 --- a/test/e2e/e2e_topologyspreadconstraint_test.go +++ b/test/e2e/e2e_topologyspreadconstraint_test.go @@ -10,7 +10,6 @@ import ( v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "sigs.k8s.io/descheduler/pkg/apis/componentconfig" "sigs.k8s.io/descheduler/pkg/framework" frameworkfake "sigs.k8s.io/descheduler/pkg/framework/fake" "sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor" @@ -103,7 +102,7 @@ func TestTopologySpreadConstraint(t *testing.T) { t.Fatalf("Unable to initialize the plugin: %v", err) } - plugin, err := removepodsviolatingtopologyspreadconstraint.New(&componentconfig.RemovePodsViolatingTopologySpreadConstraintArgs{ + plugin, err := removepodsviolatingtopologyspreadconstraint.New(&removepodsviolatingtopologyspreadconstraint.RemovePodsViolatingTopologySpreadConstraintArgs{ IncludeSoftConstraints: tc.constraint != v1.DoNotSchedule, }, &frameworkfake.HandleImpl{