diff --git a/pkg/tracing/tracing.go b/pkg/tracing/tracing.go index 53cb4f7fc..ce6f656f8 100644 --- a/pkg/tracing/tracing.go +++ b/pkg/tracing/tracing.go @@ -121,7 +121,7 @@ func NewTracerProvider(ctx context.Context, endpoint, caCert, name, namespace st klog.V(5).InfoS("no name provided, using default service name for tracing", "name", DefaultServiceName) name = DefaultServiceName } - resourceOpts := []sdkresource.Option{sdkresource.WithAttributes(semconv.ServiceNameKey.String(name)), sdkresource.WithSchemaURL(semconv.SchemaURL), sdkresource.WithProcess()} + resourceOpts := defaultResourceOpts(name) if namespace != "" { resourceOpts = append(resourceOpts, sdkresource.WithAttributes(semconv.ServiceNamespaceKey.String(namespace))) } @@ -141,6 +141,10 @@ func NewTracerProvider(ctx context.Context, endpoint, caCert, name, namespace st return } +func defaultResourceOpts(name string) []sdkresource.Option { + return []sdkresource.Option{sdkresource.WithAttributes(semconv.ServiceNameKey.String(name)), sdkresource.WithSchemaURL(semconv.SchemaURL), sdkresource.WithProcess()} +} + // Shutdown shuts down the global trace exporter. func Shutdown(ctx context.Context) error { tp, ok := provider.(*sdktrace.TracerProvider) diff --git a/pkg/tracing/tracing_test.go b/pkg/tracing/tracing_test.go new file mode 100644 index 000000000..683a39335 --- /dev/null +++ b/pkg/tracing/tracing_test.go @@ -0,0 +1,17 @@ +package tracing + +import ( + "context" + "testing" + + sdkresource "go.opentelemetry.io/otel/sdk/resource" +) + +func TestCreateTraceableResource(t *testing.T) { + ctx := context.TODO() + resourceOpts := defaultResourceOpts("descheduler") + _, err := sdkresource.New(ctx, resourceOpts...) + if err != nil { + t.Errorf("error initialising tracer provider: %!", err) + } +}