1
0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-26 05:14:13 +01:00

refactor(TestDefaultEvictor): add setPodPVCVolumeWithFooClaimName helper function

This commit is contained in:
Jan Chaloupka
2025-12-20 14:30:33 +01:00
parent 90e4115b78
commit 994ce3e2f7

View File

@@ -290,6 +290,17 @@ func TestDefaultEvictorFilter(t *testing.T) {
} }
} }
setPodPVCVolumeWithFooClaimName := func(pod *v1.Pod) {
pod.Spec.Volumes = []v1.Volume{
{
Name: "pvc",
VolumeSource: v1.VolumeSource{
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{ClaimName: "foo"},
},
},
}
}
ownerRefUUID := uuid.NewUUID() ownerRefUUID := uuid.NewUUID()
testCases := []testCase{ testCases := []testCase{
@@ -676,13 +687,7 @@ func TestDefaultEvictorFilter(t *testing.T) {
pods: []*v1.Pod{ pods: []*v1.Pod{
buildTestPod("p15", n1.Name, func(pod *v1.Pod) { buildTestPod("p15", n1.Name, func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Spec.Volumes = []v1.Volume{ setPodPVCVolumeWithFooClaimName(pod)
{
Name: "pvc", VolumeSource: v1.VolumeSource{
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{ClaimName: "foo"},
},
},
}
}), }),
}, },
ignorePvcPods: true, ignorePvcPods: true,
@@ -692,13 +697,7 @@ func TestDefaultEvictorFilter(t *testing.T) {
pods: []*v1.Pod{ pods: []*v1.Pod{
buildTestPod("p15", n1.Name, func(pod *v1.Pod) { buildTestPod("p15", n1.Name, func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Spec.Volumes = []v1.Volume{ setPodPVCVolumeWithFooClaimName(pod)
{
Name: "pvc", VolumeSource: v1.VolumeSource{
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{ClaimName: "foo"},
},
},
}
}), }),
}, },
result: true, result: true,
@@ -745,13 +744,7 @@ func TestDefaultEvictorFilter(t *testing.T) {
pods: []*v1.Pod{ pods: []*v1.Pod{
buildTestPod("p20", n1.Name, func(pod *v1.Pod) { buildTestPod("p20", n1.Name, func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Spec.Volumes = []v1.Volume{ setPodPVCVolumeWithFooClaimName(pod)
{
Name: "pvc", VolumeSource: v1.VolumeSource{
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{ClaimName: "foo"},
},
},
}
}), }),
}, },
podProtections: PodProtections{ podProtections: PodProtections{
@@ -792,15 +785,7 @@ func TestDefaultEvictorFilter(t *testing.T) {
pods: []*v1.Pod{ pods: []*v1.Pod{
buildTestPod("p23", n1.Name, func(pod *v1.Pod) { buildTestPod("p23", n1.Name, func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Spec.Volumes = []v1.Volume{ setPodPVCVolumeWithFooClaimName(pod)
{
Name: "pvc", VolumeSource: v1.VolumeSource{
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
ClaimName: "foo",
},
},
},
}
}), }),
}, },
podProtections: PodProtections{ podProtections: PodProtections{
@@ -825,15 +810,7 @@ func TestDefaultEvictorFilter(t *testing.T) {
pods: []*v1.Pod{ pods: []*v1.Pod{
buildTestPod("p24", n1.Name, func(pod *v1.Pod) { buildTestPod("p24", n1.Name, func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Spec.Volumes = []v1.Volume{ setPodPVCVolumeWithFooClaimName(pod)
{
Name: "pvc", VolumeSource: v1.VolumeSource{
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
ClaimName: "foo",
},
},
},
}
}), }),
}, },
podProtections: PodProtections{ podProtections: PodProtections{
@@ -858,15 +835,7 @@ func TestDefaultEvictorFilter(t *testing.T) {
pods: []*v1.Pod{ pods: []*v1.Pod{
buildTestPod("p25", n1.Name, func(pod *v1.Pod) { buildTestPod("p25", n1.Name, func(pod *v1.Pod) {
test.SetNormalOwnerRef(pod) test.SetNormalOwnerRef(pod)
pod.Spec.Volumes = []v1.Volume{ setPodPVCVolumeWithFooClaimName(pod)
{
Name: "pvc", VolumeSource: v1.VolumeSource{
PersistentVolumeClaim: &v1.PersistentVolumeClaimVolumeSource{
ClaimName: "foo",
},
},
},
}
}), }),
}, },
podProtections: PodProtections{ podProtections: PodProtections{