From 8dada7959375ce6444dfae2ef26f6ccfe8ff4f37 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Sun, 14 Dec 2025 12:33:00 +0100 Subject: [PATCH] refactor(TestFindDuplicatePods): have a pod fully created through BuildTestPod without any edits --- .../removeduplicates/removeduplicates_test.go | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/pkg/framework/plugins/removeduplicates/removeduplicates_test.go b/pkg/framework/plugins/removeduplicates/removeduplicates_test.go index e66da0009..aeb3198ff 100644 --- a/pkg/framework/plugins/removeduplicates/removeduplicates_test.go +++ b/pkg/framework/plugins/removeduplicates/removeduplicates_test.go @@ -135,8 +135,15 @@ func TestFindDuplicatePods(t *testing.T) { pod.Spec.Containers[0].Image = "bar" pod.ObjectMeta.OwnerReferences = ownerRef1 }) - p13 := test.BuildTestPod("p13", 100, 0, node1.Name, nil) - p13.Namespace = "different-images" + // Multiple containers + p13 := test.BuildTestPod("p13", 100, 0, node1.Name, func(pod *v1.Pod) { + pod.Namespace = "different-images" + pod.ObjectMeta.OwnerReferences = ownerRef1 + pod.Spec.Containers = append(pod.Spec.Containers, v1.Container{ + Name: "foo", + Image: "foo", + }) + }) p14 := test.BuildTestPod("p14", 100, 0, node1.Name, nil) p14.Namespace = "different-images" p15 := test.BuildTestPod("p15", 100, 0, node1.Name, nil) @@ -160,13 +167,6 @@ func TestFindDuplicatePods(t *testing.T) { // ### Non-evictable Pods ### - // Multiple containers - p13.ObjectMeta.OwnerReferences = ownerRef1 - p13.Spec.Containers = append(p13.Spec.Containers, v1.Container{ - Name: "foo", - Image: "foo", - }) - // ### Pods Evictable Based On Node Fit ### ownerRef3 := test.GetReplicaSetOwnerRefList()