Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-26 05:14:13 +01:00
Code Packages Releases Activity

refactor(TestPodLifeTime): inline pod creation in each unit test to avoid accidental pod spec updates

Browse Source
This commit is contained in:
Jan Chaloupka
2025-12-10 16:05:01 +01:00
parent 1d7368b58d
commit 822a1d4c40
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/framework/plugins/podlifetime/pod_lifetime_test.go
View File

@@ -70,9 +70,6 @@ func TestPodLifeTime(t *testing.T) {
}) })
} }
p14 := buildTestPodWithRSOwnerRefForNode1("p14", olderPodCreationTime, func(pod *v1.Pod) {
pod.DeletionTimestamp = &metav1.Time{}
})
p15 := buildTestPodWithRSOwnerRefForNode1("p15", olderPodCreationTime, func(pod *v1.Pod) { p15 := buildTestPodWithRSOwnerRefForNode1("p15", olderPodCreationTime, func(pod *v1.Pod) {
pod.DeletionTimestamp = &metav1.Time{} pod.DeletionTimestamp = &metav1.Time{}
}) })
@@ -269,7 +266,12 @@ func TestPodLifeTime(t *testing.T) {
MatchLabels: map[string]string{"foo": "bar"}, MatchLabels: map[string]string{"foo": "bar"},
}, },
}, },
pods: []*v1.Pod{p14, p15}, pods: []*v1.Pod{
buildTestPodWithRSOwnerRefForNode1("p14", olderPodCreationTime, func(pod *v1.Pod) {
pod.DeletionTimestamp = &metav1.Time{}
}),
p15,
},
nodes: []*v1.Node{buildTestNode1()}, nodes: []*v1.Node{buildTestNode1()},
expectedEvictedPodCount: 0, expectedEvictedPodCount: 0,
}, },