From 6b6f7ba5c7f87c1d6c72002830611699a9bb8a33 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Mon, 15 Dec 2025 17:24:53 +0100 Subject: [PATCH] refactor(node_taint_test): inline node5 --- .../node_taint_test.go | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go index 2421ca3e1..dd0365e90 100644 --- a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go +++ b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go @@ -114,8 +114,6 @@ func addTolerationToPod(pod *v1.Pod, key, value string, index int, effect v1.Tai } func TestDeletePodsViolatingNodeTaints(t *testing.T) { - node5 := buildTestNode(nodeName5, withPreferNoScheduleTestTaint1) - node6 := test.BuildTestNode(nodeName6, 1, 1, 1, withPreferNoScheduleTestTaint1) node7 := buildTestNode(nodeName7, withBothTaints1) @@ -338,15 +336,19 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { nodeFit: true, }, { - description: "Pods not tolerating PreferNoSchedule node taint should not be evicted when not enabled", - pods: []*v1.Pod{p13}, - nodes: []*v1.Node{node5}, + description: "Pods not tolerating PreferNoSchedule node taint should not be evicted when not enabled", + pods: []*v1.Pod{p13}, + nodes: []*v1.Node{ + buildTestNode(nodeName5, withPreferNoScheduleTestTaint1), + }, expectedEvictedPodCount: 0, }, { - description: "Pods not tolerating PreferNoSchedule node taint should be evicted when enabled", - pods: []*v1.Pod{p13}, - nodes: []*v1.Node{node5}, + description: "Pods not tolerating PreferNoSchedule node taint should be evicted when enabled", + pods: []*v1.Pod{p13}, + nodes: []*v1.Node{ + buildTestNode(nodeName5, withPreferNoScheduleTestTaint1), + }, includePreferNoSchedule: true, expectedEvictedPodCount: 1, // p13 gets evicted },