From 58408d710bf513f7022a185a936be0229ce23044 Mon Sep 17 00:00:00 2001 From: Mike Dame Date: Fri, 30 Apr 2021 16:40:46 -0400 Subject: [PATCH] Update error messages in verify scripts to be more informative --- Makefile | 1 + hack/verify-conversions.sh | 2 +- hack/verify-deep-copies.sh | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 73f43cfc2..1c5fef127 100644 --- a/Makefile +++ b/Makefile @@ -93,6 +93,7 @@ push-all: image.amd64 image.arm image.arm64 clean: rm -rf _output + rm -rf _tmp verify: verify-gofmt verify-vendor lint lint-chart verify-spelling verify-toc verify-gen diff --git a/hack/verify-conversions.sh b/hack/verify-conversions.sh index 1b698cce5..53e932cba 100755 --- a/hack/verify-conversions.sh +++ b/hack/verify-conversions.sh @@ -28,7 +28,7 @@ pushd "${DESCHEDULER_ROOT}" > /dev/null 2>&1 if ! _out="$(diff -Naupr pkg/ "${_deschedulertmp}/pkg/")"; then echo "Generated output differs:" >&2 echo "${_out}" >&2 - echo "Generated conversions verify failed. Please run ./hack/update-conversions.sh" + echo "Generated conversions verify failed. Please run ./hack/update-generated-conversions.sh (and commit the result)" exit 1 fi popd > /dev/null 2>&1 diff --git a/hack/verify-deep-copies.sh b/hack/verify-deep-copies.sh index e8d4a5f9d..b560bd11e 100755 --- a/hack/verify-deep-copies.sh +++ b/hack/verify-deep-copies.sh @@ -28,7 +28,7 @@ pushd "${DESCHEDULER_ROOT}" > /dev/null 2>&1 if ! _out="$(diff -Naupr pkg/ "${_deschedulertmp}/pkg/")"; then echo "Generated deep-copies output differs:" >&2 echo "${_out}" >&2 - echo "Generated deep-copies verify failed. Please run ./hack/update-deep-copies.sh" + echo "Generated deep-copies verify failed. Please run ./hack/update-generated-deep-copies.sh (and commit the result)" exit 1 fi popd > /dev/null 2>&1