From 57a3e610a716ed35daab7e18a5d756790b97cd15 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Mon, 15 Dec 2025 14:06:05 +0100 Subject: [PATCH] refactor(TestPodAntiAffinity): deduplicate p1, p3, p4 builders --- .../pod_antiaffinity_test.go | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity_test.go b/pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity_test.go index b96acf141..7ad9f4d19 100644 --- a/pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity_test.go +++ b/pkg/framework/plugins/removepodsviolatinginterpodantiaffinity/pod_antiaffinity_test.go @@ -79,13 +79,17 @@ func setLabelsFoo1Bar1(pod *v1.Pod) { pod.Labels = map[string]string{"foo1": "bar1"} } -func buildTestPodP1ForNode1() *v1.Pod { - return buildTestPodForNode1("p1", func(pod *v1.Pod) { +func buildTestPodWithAntiAffinityForNode1(name string) *v1.Pod { + return buildTestPodForNode1(name, func(pod *v1.Pod) { test.SetNormalOwnerRef(pod) setPodAntiAffinityFooBar(pod) }) } +func buildTestPodP1ForNode1() *v1.Pod { + return buildTestPodWithAntiAffinityForNode1("p1") +} + func buildTestPodP2ForNode1() *v1.Pod { return buildTestPodForNode1("p2", func(pod *v1.Pod) { test.SetNormalOwnerRef(pod) @@ -94,17 +98,11 @@ func buildTestPodP2ForNode1() *v1.Pod { } func buildTestPodP3ForNode1() *v1.Pod { - return buildTestPodForNode1("p3", func(pod *v1.Pod) { - test.SetNormalOwnerRef(pod) - setPodAntiAffinityFooBar(pod) - }) + return buildTestPodWithAntiAffinityForNode1("p3") } func buildTestPodP4ForNode1() *v1.Pod { - return buildTestPodForNode1("p4", func(pod *v1.Pod) { - test.SetNormalOwnerRef(pod) - setPodAntiAffinityFooBar(pod) - }) + return buildTestPodWithAntiAffinityForNode1("p4") } func buildTestPodNonEvictableForNode1() *v1.Pod {