From 43523113ffb2c13f82d2fa214c9bfca3651540dd Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Mon, 15 Dec 2025 16:42:34 +0100 Subject: [PATCH] refactor(node_taint_test): apply pod single creation convention for p7 --- .../node_taint_test.go | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go index 3bbd5bda7..22797e4cf 100644 --- a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go +++ b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go @@ -144,13 +144,17 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { p6 := buildTestPod("p6", nodeName1, func(pod *v1.Pod) { pod.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() }) - p7 := buildTestPod("p7", nodeName2, nil) + p7 := buildTestPod("p7", nodeName2, func(pod *v1.Pod) { + pod.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() + pod.Namespace = "kube-system" + priority := utils.SystemCriticalPriority + pod.Spec.Priority = &priority + }) p8 := buildTestPod("p8", nodeName2, nil) p9 := buildTestPod("p9", nodeName2, nil) p10 := buildTestPod("p10", nodeName2, nil) p11 := buildTestPod("p11", nodeName2, nil) p12 := buildTestPod("p11", nodeName2, nil) - p7.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() p8.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() p9.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() p10.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() @@ -159,11 +163,6 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { // The following 4 pods won't get evicted. // A Critical Pod. - p7.Namespace = "kube-system" - priority := utils.SystemCriticalPriority - p7.Spec.Priority = &priority - p7.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() - // A daemonset. p8.ObjectMeta.OwnerReferences = test.GetDaemonSetOwnerRefList() // A pod with local storage.