From 3f0c06b58d526b450188ea4c94df43159a886d93 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antoine=20Desch=C3=AAnes?= Date: Tue, 22 Aug 2023 13:04:06 -0400 Subject: [PATCH] profile: fix span attribute typo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix profile attribute "prpfile" typo in trace spans. Signed-off-by: Antoine Deschênes --- pkg/framework/profile/profile.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/framework/profile/profile.go b/pkg/framework/profile/profile.go index e5a05bad4..a9f0ea905 100644 --- a/pkg/framework/profile/profile.go +++ b/pkg/framework/profile/profile.go @@ -304,7 +304,7 @@ func (d profileImpl) RunDeschedulePlugins(ctx context.Context, nodes []*v1.Node) errs := []error{} for _, pl := range d.deschedulePlugins { var span trace.Span - ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("prpfile", d.profileName), attribute.String("operation", tracing.DescheduleOperation))) + ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("profile", d.profileName), attribute.String("operation", tracing.DescheduleOperation))) defer span.End() evicted := d.podEvictor.TotalEvicted() // TODO: strategyName should be accessible from within the strategy using a framework @@ -337,7 +337,7 @@ func (d profileImpl) RunBalancePlugins(ctx context.Context, nodes []*v1.Node) *f errs := []error{} for _, pl := range d.balancePlugins { var span trace.Span - ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("prpfile", d.profileName), attribute.String("operation", tracing.BalanceOperation))) + ctx, span = tracing.Tracer().Start(ctx, pl.Name(), trace.WithAttributes(attribute.String("plugin", pl.Name()), attribute.String("profile", d.profileName), attribute.String("operation", tracing.BalanceOperation))) defer span.End() evicted := d.podEvictor.TotalEvicted() // TODO: strategyName should be accessible from within the strategy using a framework