From 2648749eb89c433844e6c7dbc31ffbcf0ef7ecb3 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Wed, 10 Dec 2025 15:45:10 +0100 Subject: [PATCH] refactor(TestPodLifeTime): inline pod creation in each unit test to avoid accidental pod spec updates --- .../plugins/podlifetime/pod_lifetime_test.go | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go index 4c5d1e965..99fa3a2c1 100644 --- a/pkg/framework/plugins/podlifetime/pod_lifetime_test.go +++ b/pkg/framework/plugins/podlifetime/pod_lifetime_test.go @@ -61,9 +61,6 @@ func TestPodLifeTime(t *testing.T) { }) } - // Setup pods, one should be evicted - p2 := buildTestPodWithRSOwnerRefForNode1("p2", olderPodCreationTime, nil) - // Setup pods, zero should be evicted p3 := buildTestPodWithRSOwnerRefForNode1("p3", newerPodCreationTime, nil) p4 := buildTestPodWithRSOwnerRefForNode1("p4", newerPodCreationTime, nil) @@ -133,7 +130,7 @@ func TestPodLifeTime(t *testing.T) { }, pods: []*v1.Pod{ buildTestPodWithRSOwnerRefForNode1("p1", newerPodCreationTime, nil), - p2, + buildTestPodWithRSOwnerRefForNode1("p2", olderPodCreationTime, nil), }, nodes: []*v1.Node{buildTestNode1()}, expectedEvictedPodCount: 1, @@ -271,7 +268,7 @@ func TestPodLifeTime(t *testing.T) { }, pods: []*v1.Pod{ buildTestPodWithRSOwnerRefForNode1("p1", newerPodCreationTime, nil), - p2, + buildTestPodWithRSOwnerRefForNode1("p2", olderPodCreationTime, nil), p9, }, nodes: []*v1.Node{buildTestNode1()}, @@ -286,7 +283,7 @@ func TestPodLifeTime(t *testing.T) { }, pods: []*v1.Pod{ buildTestPodWithRSOwnerRefForNode1("p1", newerPodCreationTime, nil), - p2, + buildTestPodWithRSOwnerRefForNode1("p2", olderPodCreationTime, nil), p9, }, nodes: []*v1.Node{buildTestNode1()}, @@ -300,7 +297,7 @@ func TestPodLifeTime(t *testing.T) { }, pods: []*v1.Pod{ buildTestPodWithRSOwnerRefForNode1("p1", newerPodCreationTime, nil), - p2, + buildTestPodWithRSOwnerRefForNode1("p2", olderPodCreationTime, nil), p9, }, nodes: []*v1.Node{buildTestNode1()}, @@ -315,7 +312,7 @@ func TestPodLifeTime(t *testing.T) { }, pods: []*v1.Pod{ buildTestPodWithRSOwnerRefForNode1("p1", newerPodCreationTime, nil), - p2, + buildTestPodWithRSOwnerRefForNode1("p2", olderPodCreationTime, nil), p9, }, nodes: []*v1.Node{buildTestNode1()},