From 1f7bd1fba9faaaf9899d9a684e2baedfe3a7b167 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Mon, 15 Dec 2025 18:10:44 +0100 Subject: [PATCH] refactor(node_taint_test): inline p13 --- .../node_taint_test.go | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go index 0bbece49c..2a629a063 100644 --- a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go +++ b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go @@ -162,9 +162,6 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { // node5 has PreferNoSchedule:testTaint1=test1, so the p13 has to have // PreferNoSchedule:testTaint0=test0 so the pod is not tolarated - p13 := buildTestPodWithNormalOwnerRef("p13", nodeName5, func(pod *v1.Pod) { - addTolerationToPod(pod, "testTaint", "test", 0, v1.TaintEffectPreferNoSchedule) - }) p14 := buildTestPodWithNormalOwnerRef("p14", nodeName7, withTestTaintToleration1) @@ -370,7 +367,11 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { }, { description: "Pods not tolerating PreferNoSchedule node taint should not be evicted when not enabled", - pods: []*v1.Pod{p13}, + pods: []*v1.Pod{ + buildTestPodWithNormalOwnerRef("p13", nodeName5, func(pod *v1.Pod) { + addTolerationToPod(pod, "testTaint", "test", 0, v1.TaintEffectPreferNoSchedule) + }), + }, nodes: []*v1.Node{ buildTestNode(nodeName5, withPreferNoScheduleTestTaint1), }, @@ -378,7 +379,11 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { }, { description: "Pods not tolerating PreferNoSchedule node taint should be evicted when enabled", - pods: []*v1.Pod{p13}, + pods: []*v1.Pod{ + buildTestPodWithNormalOwnerRef("p13", nodeName5, func(pod *v1.Pod) { + addTolerationToPod(pod, "testTaint", "test", 0, v1.TaintEffectPreferNoSchedule) + }), + }, nodes: []*v1.Node{ buildTestNode(nodeName5, withPreferNoScheduleTestTaint1), },