Sok3t/descheduler
1
0
Fork 0
mirror of https://github.com/kubernetes-sigs/descheduler.git synced 2026-01-26 05:14:13 +01:00
Code Packages Releases Activity

Merge pull request #856 from a7i/pod-sort-age-random

Browse Source 
remove random creation timestamp from pod sort by age test
This commit is contained in:
Kubernetes Prow Robot
2022-06-16 01:18:49 -07:00
committed by GitHub
parent 627d219dab a7cfb25e9b
commit 1f1aad335a
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/descheduler/pod/pods_test.go
View File

@@ -19,7 +19,6 @@ package pod
import (
"context"
"fmt"
"math/rand"
"reflect"
"testing"
"time"
@@ -164,20 +163,16 @@ func TestSortPodsBasedOnAge(t *testing.T) {
for i := 0; i < len(podList); i++ {
podList[i] = test.BuildTestPod(fmt.Sprintf("p%d", i), 1, 32, n1.Name, func(pod *v1.Pod) {
creationTimestamp := metav1.Now().Add(time.Minute * time.Duration(i))
creationTimestamp := metav1.Now().Add(time.Minute * time.Duration(-i))
pod.ObjectMeta.SetCreationTimestamp(metav1.NewTime(creationTimestamp))
})
}
rand.Seed(time.Now().UnixNano())
rand.Shuffle(len(podList), func(i, j int) { podList[i], podList[j] = podList[j], podList[i] })
SortPodsBasedOnAge(podList)
for i := 0; i < len(podList); i++ {
expectedName := fmt.Sprintf("p%d", i)
if podList[i].GetName() != expectedName {
t.Errorf("Expected pod %s to be at index %d", expectedName, i)
for i := 0; i < len(podList)-1; i++ {
if podList[i+1].CreationTimestamp.Before(&podList[i].CreationTimestamp) {
t.Errorf("Expected pods to be sorted by age but pod at index %d was older than %d", i+1, i)
}
}
}