From 6bde95c9a1bd0c5df2c2bc7b3912739a90a4b899 Mon Sep 17 00:00:00 2001 From: Sean Malloy Date: Thu, 29 Apr 2021 00:00:07 -0500 Subject: [PATCH] Use Structured Logging For Unknown Strategy Log Message Always use structured logging. Therefore update klog.Errorf() to instead use klog.ErrorS(). Here is an example of the new log message. E0428 23:58:57.048912 586 descheduler.go:145] "skipping strategy" err="unknown strategy name" strategy=ASDFPodLifeTime --- pkg/descheduler/descheduler.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/descheduler/descheduler.go b/pkg/descheduler/descheduler.go index fa299edaf..dd0b159d5 100644 --- a/pkg/descheduler/descheduler.go +++ b/pkg/descheduler/descheduler.go @@ -142,7 +142,7 @@ func RunDeschedulerStrategies(ctx context.Context, rs *options.DeschedulerServer f(ctx, rs.Client, strategy, nodes, podEvictor) } } else { - klog.Errorf("Unknown strategy name '%s', skipping", name) + klog.ErrorS(fmt.Errorf("unknown strategy name"), "skipping strategy", "strategy", name) } }