From 0580b5942c3d8c7b15bc914c8c72f39c9507eb78 Mon Sep 17 00:00:00 2001 From: Jan Chaloupka Date: Mon, 15 Dec 2025 16:44:46 +0100 Subject: [PATCH] refactor(node_taint_test): apply pod single creation convention for p12 --- .../removepodsviolatingnodetaints/node_taint_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go index 7f5450461..3c343fa61 100644 --- a/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go +++ b/pkg/framework/plugins/removepodsviolatingnodetaints/node_taint_test.go @@ -174,8 +174,12 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { p11 := buildTestPod("p11", nodeName2, func(pod *v1.Pod) { pod.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() }) - p12 := buildTestPod("p11", nodeName2, nil) - p12.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() + p12 := buildTestPod("p11", nodeName2, func(pod *v1.Pod) { + pod.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() + pod.Spec.NodeSelector = map[string]string{ + "datacenter": "west", + } + }) // The following 4 pods won't get evicted. // A Critical Pod. @@ -183,10 +187,6 @@ func TestDeletePodsViolatingNodeTaints(t *testing.T) { // A pod with local storage. // A Mirror Pod. - p12.Spec.NodeSelector = map[string]string{ - "datacenter": "west", - } - p13 := buildTestPod("p13", nodeName5, nil) p13.ObjectMeta.OwnerReferences = test.GetNormalPodOwnerRefList() // node5 has PreferNoSchedule:testTaint1=test1, so the p13 has to have