From 01fb826bd38d68bf08e4efd9c3826419d65dec6e Mon Sep 17 00:00:00 2001
From: Jan Chaloupka <jchaloup@redhat.com>
Date: Sun, 14 Dec 2025 13:46:05 +0100
Subject: [PATCH] refactor(TestFindDuplicatePods): inline p5 pod creation

---
 .../removeduplicates/removeduplicates_test.go | 44 ++++++++++++-------
 1 file changed, 28 insertions(+), 16 deletions(-)

diff --git a/pkg/framework/plugins/removeduplicates/removeduplicates_test.go b/pkg/framework/plugins/removeduplicates/removeduplicates_test.go
index bcf836d80..f4c15d138 100644
--- a/pkg/framework/plugins/removeduplicates/removeduplicates_test.go
+++ b/pkg/framework/plugins/removeduplicates/removeduplicates_test.go
@@ -94,20 +94,6 @@ func TestFindDuplicatePods(t *testing.T) {
 	// Three Pods in the "dev" Namespace, bound to same ReplicaSet. 2 should be evicted.
 	// A DaemonSet.
 	// A Pod with local storage.
-	p5 := buildTestPodForNode1("p5", func(pod *v1.Pod) {
-		test.SetNormalOwnerRef(pod)
-		pod.Spec.Volumes = []v1.Volume{
-			{
-				Name: "sample",
-				VolumeSource: v1.VolumeSource{
-					HostPath: &v1.HostPathVolumeSource{Path: "somePath"},
-					EmptyDir: &v1.EmptyDirVolumeSource{
-						SizeLimit: resource.NewQuantity(int64(10), resource.BinarySI),
-					},
-				},
-			},
-		}
-	})
 	// A Mirror Pod.
 	p6 := buildTestPodForNode1("p6", func(pod *v1.Pod) {
 		pod.Annotations = test.GetMirrorPodAnnotation()
@@ -219,7 +205,20 @@ func TestFindDuplicatePods(t *testing.T) {
 				buildTestPodForNode1("p4", func(pod *v1.Pod) {
 					test.SetDSOwnerRef(pod)
 				}),
-				p5, p6, p7,
+				buildTestPodForNode1("p5", func(pod *v1.Pod) {
+					test.SetNormalOwnerRef(pod)
+					pod.Spec.Volumes = []v1.Volume{
+						{
+							Name: "sample",
+							VolumeSource: v1.VolumeSource{
+								HostPath: &v1.HostPathVolumeSource{Path: "somePath"},
+								EmptyDir: &v1.EmptyDirVolumeSource{
+									SizeLimit: resource.NewQuantity(int64(10), resource.BinarySI),
+								},
+							},
+						},
+					}
+				}), p6, p7,
 			},
 			nodes:                   []*v1.Node{node1, node2},
 			expectedEvictedPodCount: 0,
@@ -233,7 +232,20 @@ func TestFindDuplicatePods(t *testing.T) {
 				buildTestPodForNode1("p4", func(pod *v1.Pod) {
 					test.SetDSOwnerRef(pod)
 				}),
-				p5, p6, p7, p8, p9, p10,
+				buildTestPodForNode1("p5", func(pod *v1.Pod) {
+					test.SetNormalOwnerRef(pod)
+					pod.Spec.Volumes = []v1.Volume{
+						{
+							Name: "sample",
+							VolumeSource: v1.VolumeSource{
+								HostPath: &v1.HostPathVolumeSource{Path: "somePath"},
+								EmptyDir: &v1.EmptyDirVolumeSource{
+									SizeLimit: resource.NewQuantity(int64(10), resource.BinarySI),
+								},
+							},
+						},
+					}
+				}), p6, p7, p8, p9, p10,
 			},
 			nodes:                   []*v1.Node{node1, node2},
 			expectedEvictedPodCount: 2,